[css-color-4] correct blend() adjuster calculation #2197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tabatkins is it worth accepting corrections to the adjusters, given we want to rethink them from scratch? |
Contributor
Author
|
I believe it will be helpful to have the correct information in your existing reference. I do hope it is worth it. As an idea, tinting a color 0%, or mixing 0% black with a color should not turn that color 100% black. |
Member
|
Yeah, might as well fix it while it's here. |
Contributor
|
Agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the
blend()adjuster calculation so that a base color does not change when a specified color is 0% blended in.This will consequently correct
tint()andshade()adjusters, as they rely on the behavior ofblend().Resolves #2195