Removed Overview.html to let Bikeshed be run automatically on the server (issue #213) #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the specs I edit were affected by this change. For the record, I am OK with it. However, I know that some of the specs were intentionally kept that way by their editor, and I am not sure it is appropriate to do this change without the editor's consent. In particular, I know that @dbaron did it intentionally. I don't know if that is still his position, but it would be good to check. |
|
In the end it was Tab's decision to merge the PR, though if some editors have a problem with this, they should raise their voice in issue #213 (and maybe add the Overview.html back in case they have really good reasons for doing so). Sebastian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.