Move effects of containment on regions from [css-contain-1] to [css-regions-1] #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astearns
reviewed
Feb 15, 2018
|
|
||
| A <a>CSS region</a> is deemed to be the <dfn lt="last usable region | last usable CSS region">last usable region</dfn> | ||
| in a <a>region chain</a> | ||
| if it is the first region in that chain to have <a>layout containment</a>, |
There was a problem hiding this comment.
Could you add a "(See [[!CSS-CONTAIN-1]])" here?
astearns
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1872 (comment), this PR moves the effect of containment on regions from the containment spec to the regions spec.
@astearns I vouch for the css-contain part of this patch. Can you review (and hopefully approve, then merge) the css-regions part?