Skip to content

Use <custom-ident> consistently for counter names #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Mar 2, 2018

The functions counter() and counters() were badly specified, using
<ident> for the counter names, even though counter-increment and friends
will only accept <custom-ident> for those names.

The functions `counter()` and `counters()` were badly specified, using
`<ident>` for the counter names, even though `counter-increment` and friends
will only accept `<custom-ident>` for those names.
nox added a commit to servo/servo that referenced this pull request Mar 2, 2018
servo-wpt-sync pushed a commit to servo-wpt-sync/web-platform-tests that referenced this pull request Mar 2, 2018
@nox
Copy link
Contributor Author

nox commented Mar 2, 2018

There is a test for this in servo/servo#20171.

@tabatkins tabatkins merged commit cb834e9 into w3c:master Mar 2, 2018
bors-servo pushed a commit to servo/servo that referenced this pull request Mar 2, 2018
 Make ContentItem use a CustomIdent for counter names

See w3c/csswg-drafts#2377.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20171)
<!-- Reviewable:end -->
@nox nox deleted the counters-are-named-with-custom-idents branch March 2, 2018 17:09
jdm pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 2, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 2, 2018
…names (from servo:content-item-counters); r=emilio

See w3c/csswg-drafts#2377.

Source-Repo: https://github.com/servo/servo
Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c3dbd3ab4fa0904e06e2ca01318b2e08c979b3a7
nupurbaghel pushed a commit to paavininanda/servo that referenced this pull request Mar 14, 2018
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 2, 2019
…names (from servo:content-item-counters); r=emilio

See w3c/csswg-drafts#2377.

Source-Repo: https://github.com/servo/servo
Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579

UltraBlame original commit: af8624334733a2d71ba39fa873ed0c903e6e4449
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 2, 2019
…names (from servo:content-item-counters); r=emilio

See w3c/csswg-drafts#2377.

Source-Repo: https://github.com/servo/servo
Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579

UltraBlame original commit: af8624334733a2d71ba39fa873ed0c903e6e4449
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 2, 2019
…names (from servo:content-item-counters); r=emilio

See w3c/csswg-drafts#2377.

Source-Repo: https://github.com/servo/servo
Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579

UltraBlame original commit: af8624334733a2d71ba39fa873ed0c903e6e4449
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
…names (from servo:content-item-counters); r=emilio

See w3c/csswg-drafts#2377.

Source-Repo: https://github.com/servo/servo
Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants