Use <custom-ident> consistently for counter names
#2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions `counter()` and `counters()` were badly specified, using `<ident>` for the counter names, even though `counter-increment` and friends will only accept `<custom-ident>` for those names.
nox
added a commit
to servo/servo
that referenced
this pull request
Mar 2, 2018
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Mar 2, 2018
|
There is a test for this in servo/servo#20171. |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Mar 2, 2018
Make ContentItem use a CustomIdent for counter names See w3c/csswg-drafts#2377. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20171) <!-- Reviewable:end -->
jdm
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 2, 2018
See w3c/csswg-drafts#2377 Upstreamed from servo/servo#20171 [ci skip]
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 2, 2018
…names (from servo:content-item-counters); r=emilio See w3c/csswg-drafts#2377. Source-Repo: https://github.com/servo/servo Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : c3dbd3ab4fa0904e06e2ca01318b2e08c979b3a7
nupurbaghel
pushed a commit
to paavininanda/servo
that referenced
this pull request
Mar 14, 2018
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
…names (from servo:content-item-counters); r=emilio See w3c/csswg-drafts#2377. Source-Repo: https://github.com/servo/servo Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579 UltraBlame original commit: af8624334733a2d71ba39fa873ed0c903e6e4449
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…names (from servo:content-item-counters); r=emilio See w3c/csswg-drafts#2377. Source-Repo: https://github.com/servo/servo Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579 UltraBlame original commit: af8624334733a2d71ba39fa873ed0c903e6e4449
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
…names (from servo:content-item-counters); r=emilio See w3c/csswg-drafts#2377. Source-Repo: https://github.com/servo/servo Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579 UltraBlame original commit: af8624334733a2d71ba39fa873ed0c903e6e4449
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…names (from servo:content-item-counters); r=emilio See w3c/csswg-drafts#2377. Source-Repo: https://github.com/servo/servo Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
counter()andcounters()were badly specified, using<ident>for the counter names, even thoughcounter-incrementand friendswill only accept
<custom-ident>for those names.