Add :focus-visible recommendation for tabindex/appearance. #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice
reviewed
Mar 6, 2018
| @@ -2295,6 +2295,30 @@ The Focus-Indicated Pseudo-class: '':focus-visible''</h3> | |||
| apply '':focus-visible''. | |||
| </div> | |||
|
|
|||
| <div class="note"> | |||
| Note: It is a common practice by UAs to always draw a focus indicator on any | |||
There was a problem hiding this comment.
I would replace this with a note about UA stylesheets and :focus as the usual mechanism for showing a focus ring, except in a few cases concerning elements which have their default appearance and exhibit something like the behaviour :focus-visible should emulate.
Then, follow up with a comment about the eventual goal being to recommend UAs use :focus-visible in place of :focus so that the default behaviour will be more nuanced.
|
I'm going to close this PR while we wordsmith this a bit more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the
:focus-visiblespec says it's up to the UA's heuristic to determine when to match, I wanted to add a note to recommend that:focus-visiblenot match on mouse-focused elements withtabindex=0or modifiedappearance. What do y'all think?cc @alice @bkardell @tabatkins