-
Notifications
You must be signed in to change notification settings - Fork 765
Added 'Privacy and Security Considerations' section to CSS Bikeshed Module #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
[css-module-bikeshed] Added 'Privacy and Security Considerations'
section
- Loading branch information
commit b671f428f30663cc026dfd5ba767f05a91e9fbb1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making this “Make some considerations about privacy and security.” into an issue, to make sure it doesn't get forgotten?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion about that, but there is no other issue marking a 'must edit'.
Sebastian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, adding this to the template only serves to silence a Bikeshed warning telling you you need to write this part. If we replace the warning with an issue in the spec, that's fine, but there was a reason for that warning: this is a part of the spec that is at risk of being forgotten unless you are explicitly reminded about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That it can be easily forgotten is one reason I opened issue #240.
Obviously very few editors actually added this section to their specs so far. So it seemed to me the Bikeshed warning is not enough and I was wondering about how to push people more to add that section.
It's ok for me to add an issue instead, though before I do that I'm asking about this at #240 (comment).
Sebastian