Skip to content

Conversation

@frivoal
Copy link
Collaborator

@frivoal frivoal commented Mar 20, 2018

Closes #2455

@frivoal frivoal added the css-text-3 Current Work label Mar 20, 2018
@frivoal frivoal requested review from fantasai and r12a March 20, 2018 00:43
Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The division of the Thai looks correct to me, and certainly mirrors what browsers actually do.
The full stop at the end got me a little confused initially, until i saw that it was part of the larger example, but even so it's a bit strange, especially given that the example sentence starts with Chinese.
(I'll raise a separate issue anyway, because there are no break points before the punctuation in wb:break-all.)

@r12a
Copy link
Contributor

r12a commented Mar 21, 2018

(I'll raise a separate issue anyway, because there are no break points before the punctuation in wb:break-all.)

Ah, i may be confused about the difference between word-break:all and line-break:anywhere again.

@frivoal
Copy link
Collaborator Author

frivoal commented Mar 21, 2018

even so it's a bit strange, especially given that the example sentence starts with Chinese

I don not believe that there are established punctuation conventions for text that spans 4 unrelated writing systems, so a full stop is just as good as anything else. The punctuation is indeed there to show word-break:break-all has no expected effect on punctuation (as line-break:anywhere is what does that).

Ah, i may be confused about the difference between word-break:all and line-break:anywhere again.

Yes, but I cannot blame you. These properties and values are all terribly named (although line-break:anywhere isn't the worst), but by and large we're stuck with them.

@fantasai fantasai merged commit 3a640ed into w3c:master Mar 22, 2018
@frivoal frivoal deleted the css-text-thai-sample branch March 22, 2018 01:54
@frivoal
Copy link
Collaborator Author

frivoal commented Mar 22, 2018

I am so confused at how github works. Why is it that I made this commit, you merged it, and the commit history shows you as the author of this commit? Not of the merge commit, of the actual commit.

I noticed because twitter told me you fixed this, and I was wondering why you didn't merge the commit I had made. Maybe I had got it wrong somehow? I cannot read Thai, so it is very possible. But no, it turns out you did merge my PR, but github claims you wrote it. Probably a side effect of rebase-and-merge?

I don't care about being given credit for this particular commit, but I it seems bad that github seems to be messing with attribution in general. Beyond affecting who gets credit, it will also hide that the spec has external contributors when their Pull Requests get merged by WG members, which seems problematic from an IP point of view.

@fantasai did you do something unusual when merging this, making my worries about github unfounded?

@fantasai
Copy link
Collaborator

I committed the same changes as you, and then realized you had made a PR for them, and so I just merged it--which was a valid action, but merged an empty diff, so it closed the PR without adding a changeset into the logs.

@frivoal
Copy link
Collaborator Author

frivoal commented Mar 23, 2018

Aha. Makes more sense. So much for my conspiracy theory about github's evil rewriting :)

@frivoal frivoal added the Tested Memory aid - issue has WPT tests label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css-text-3 Current Work Tested Memory aid - issue has WPT tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[css-text] Questionable Thai words

3 participants