-
Notifications
You must be signed in to change notification settings - Fork 756
[css-text-3] Fix Thai sample #2457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r12a
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The division of the Thai looks correct to me, and certainly mirrors what browsers actually do.
The full stop at the end got me a little confused initially, until i saw that it was part of the larger example, but even so it's a bit strange, especially given that the example sentence starts with Chinese.
(I'll raise a separate issue anyway, because there are no break points before the punctuation in wb:break-all.)
Ah, i may be confused about the difference between word-break:all and line-break:anywhere again. |
I don not believe that there are established punctuation conventions for text that spans 4 unrelated writing systems, so a full stop is just as good as anything else. The punctuation is indeed there to show
Yes, but I cannot blame you. These properties and values are all terribly named (although |
|
I am so confused at how github works. Why is it that I made this commit, you merged it, and the commit history shows you as the author of this commit? Not of the merge commit, of the actual commit. I noticed because twitter told me you fixed this, and I was wondering why you didn't merge the commit I had made. Maybe I had got it wrong somehow? I cannot read Thai, so it is very possible. But no, it turns out you did merge my PR, but github claims you wrote it. Probably a side effect of rebase-and-merge? I don't care about being given credit for this particular commit, but I it seems bad that github seems to be messing with attribution in general. Beyond affecting who gets credit, it will also hide that the spec has external contributors when their Pull Requests get merged by WG members, which seems problematic from an IP point of view. @fantasai did you do something unusual when merging this, making my worries about github unfounded? |
|
I committed the same changes as you, and then realized you had made a PR for them, and so I just merged it--which was a valid action, but merged an empty diff, so it closed the PR without adding a changeset into the logs. |
|
Aha. Makes more sense. So much for my conspiracy theory about github's evil rewriting :) |
Closes #2455