[css-shadow-parts] rephrase to make it clear which shadow root #2467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
b836957 to
cc635be
Compare
cc635be to
5f9d66e
Compare
Contributor
Author
|
pr-preview of this is here it's against my own repo since pr-preview doesn't currently work for w3c/csswg-drafts |
kojiishi
reviewed
Jun 5, 2018
Contributor
kojiishi
left a comment
There was a problem hiding this comment.
Can you also explain why we're adding files to docs/rendered directory? I'm not familiar with it.
| Work Status: exploring | ||
| URL: http://drafts.csswg.org/css-shadow-parts/ | ||
| Editor: Tab Atkins-Bittner, Google, http://xanthir.com/contact/, w3cid 42199 | ||
| Abstract: This specification defines the ''::part()'' and ''::theme()'' pseudo-elements on <a>shadow hosts</a>, allowing <a>shadow hosts</a> to selectively expose chosen elements from their <a>shadow tree</a> to the outside page for styling purposes. |
Contributor
There was a problem hiding this comment.
Can you explain why we want to take these links out?
Contributor
Author
There was a problem hiding this comment.
That shouldn't be happening. I think I took the wrong base for this PR. I will fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with mappings on host elements there are 2 possible meanings to "shadow root" - the one attached to the host and the one containing the host. In the spec, only one makes sense, so it's unambiguous but this change makes it explicit.