Skip to content

Explain focus-visible intent and guidance. #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Explain focus-visible intent and guidance. #2481

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b1802a
Explain focus-visible intent and guidance.
robdodson Mar 28, 2018
4ed40b8
Delete redundant advisement
robdodson Mar 28, 2018
8562cd2
Update focus-visible guidance to match TAG feedback.
robdodson Apr 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete redundant advisement
  • Loading branch information
@robdodson
robdodson committed Mar 28, 2018
commit 4ed40b8eaa76e663bc6732f533098f73f31c0dc0
15 changes: 0 additions & 15 deletions selectors-4/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2260,21 +2260,6 @@ The Focus-Indicated Pseudo-class: '':focus-visible''</h3>
selectively, in order to encourage visible, usable focus styles, and
Copy link

@triblondon triblondon Apr 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a developer, personally I find the previous form of words more straightforward and easier to understand. I'm struggling particularly with the word 'selectively'. The purpose of :focus-visible is, as I understand it, to style the focus ring while not overriding the UA's discretion about whether to display it. Therefore this mechanism intentionally doesn't give the developer control over that discretion, whereas I'd interpret 'selectively' in this text as implying that it does.

I'm sorry not to be able to suggest an alternative form of words here but I don't think I have a strong enough understanding of the motivation for the change. Is there a desire to be less opinionated about developer behaviour?

discourage the practice of disabling the default user agent focus style.

<div class=advisement>
Page authors should follow these guidelines
Copy link
Member

@dbaron dbaron Apr 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a little disappointing to remove all of the advice for authors. It's not clear to me that the old advice was the best that could be offered, but this does seem like an area where it's worth offering some expert advice on what the right thing really is.

when deciding whether to use '':focus'' or '':focus-visible''
to style the focused state of an element:

* If the element has “native” focus indicator behavior
(such as text fields or buttons),
use '':focus-visible''.
* Otherwise, if the element is emulating a text input,
or something else that is <em>intended</em> to receive keyboard interaction,
use '':focus''.
* Otherwise,
use '':focus-visible''.
</div>

When UAs choose to specially indicate focus on an element,
Copy link

@alice alice Apr 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this paragraph confuses the issue about the problem we're trying to solve. The problem is the practice of disabling the default UA focus style, mentioned in the previous paragraph.

or whether they specially indicate focus at all,
is UA-dependent.
Expand Down