Skip to content

[cssom] Fix #2403 and #2149 #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2018
Merged

[cssom] Fix #2403 and #2149 #2534

merged 3 commits into from
Apr 11, 2018

Conversation

emilio
Copy link
Collaborator

@emilio emilio commented Apr 11, 2018

See individual commits for reference.

@emilio emilio requested a review from tabatkins April 11, 2018 11:57
@@ -2791,9 +2790,9 @@ steps:
<dd>All longhand properties that are <a lt="supported CSS property">supported CSS properties</a>, in lexicographical order, with the value being
the <a>resolved value</a> computed for <var>obj</var> using the style rules associated with <var>doc</var>.

Note: This means that even if <var>obj</var> is in a different document (e.g. one fetched via <code>XMLHttpRequest</code>) it will still use
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in the first commit.

the style rules associated with the document that is associated with the global object on which
{{Window/getComputedStyle()}} was invoked to compute the <a>CSS declaration block</a>.
Issue: There are UAs that handle shorthands, and all UAs handle shorthands
that used to be shorthands like 'overflow', see
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and s/shorthands/longhands/ here.

@emilio emilio merged commit 23c7881 into w3c:master Apr 11, 2018
@tabatkins tabatkins removed the ready label Apr 11, 2018
@emilio emilio deleted the first-try branch April 11, 2018 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants