Skip to content

Add links for media query terms in CSSOM - #2556

Merged
emilio merged 1 commit into
w3c:masterfrom
csnardi:cssom-linking
Apr 13, 2018
Merged

Add links for media query terms in CSSOM#2556
emilio merged 1 commit into
w3c:masterfrom
csnardi:cssom-linking

Conversation

@csnardi

@csnardi csnardi commented Apr 12, 2018

Copy link
Copy Markdown
Contributor

Also remove a bunch of ignored terms, as either these are no longer present or they since resolve properly.

Also remove a bunch of ignored terms, as either these are no longer present or they since resolve properly.

@emilio emilio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

FWIW you can use <a>Media queries</a> instead of [=Media queries=], which feels a bit nicer to edit IMO.

It doesn't matter much though, feel free to submit a followup if you want, or not, either is fine :)

@emilio
emilio merged commit e74224c into w3c:master Apr 13, 2018
@csnardi
csnardi deleted the cssom-linking branch April 14, 2018 04:17
@csnardi

csnardi commented Apr 14, 2018

Copy link
Copy Markdown
Contributor Author

@emilio I can submit a follow-up, I just wasn't sure what was preferred. :) [= =] looked fancier, but I agree that <a></a> is probably more functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants