Skip to content

[css-pseudo-4] EventTarget is not a mixin #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2019
Merged

[css-pseudo-4] EventTarget is not a mixin #2573

merged 1 commit into from
Feb 8, 2019

Conversation

@saschanaz
Copy link
Member

@saschanaz saschanaz commented Apr 15, 2018

implements is only for mixins.

@saschanaz saschanaz changed the title EventTarget is not a mixin [css-pseudo-4] EventTarget is not a mixin Apr 15, 2018
@frivoal frivoal added the css-pseudo-4 Current Work label Apr 30, 2018
@saschanaz
Copy link
Member Author

saschanaz commented Nov 13, 2018

Now implements is even an illegal syntax.

@foolip
Copy link
Member

foolip commented Feb 7, 2019

@tabatkins can you review/merge? I've run into the same problem and also had to fix it, found this PR when looking to send one myself.

@tabatkins tabatkins merged commit 02138b8 into w3c:master Feb 8, 2019
@saschanaz saschanaz deleted the patch-1 branch February 8, 2019 03:00
@foolip foolip mentioned this pull request Feb 14, 2019
Closed
@foolip
Copy link
Member

foolip commented Feb 14, 2019

Thanks @ericwilligers and @tabatkins.

This change hasn't propagated to reffy-reports yet, I've filed w3c/reffy#141 about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewilligers ewilligers ewilligers approved these changes

Assignees

No one assigned

Labels

css-pseudo-4 Current Work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saschanaz @foolip @ewilligers @frivoal @tabatkins