Deal with overflow:clip#2596
Merged
Merged
Conversation
… with overflow:clip Make sure that various specs correctly invoke either "overflow is not visible" or "is a scroll container" since these two are no longer equivalent.
Collaborator
Author
|
Requesting review: @tabatkins @fantasai @zcorpan |
Collaborator
Author
|
Merging this should close #1971 |
fantasai
approved these changes
Apr 20, 2018
Collaborator
fantasai
left a comment
There was a problem hiding this comment.
Overall looks good, but please fix the grammatical errors before merging. :)
| To provide a more reasonable default <a>minimum size</a> for <a>flex items</a>, | ||
| the used value of a <a>main axis</a> <a>automatic minimum size</a> | ||
| on a <a>flex item</a> whose 'overflow' is ''overflow/visible'' in the <a>main axis</a> | ||
| on a <a>flex item</a> which is not a <a>scroll container</a> |
| To provide a more reasonable default <a>minimum size</a> for <a>grid items</a>, | ||
| the used value of an <a>automatic minimum size</a> in a given axis | ||
| on a <a>grid item</a> whose 'overflow' is ''overflow/visible'' in that same axis | ||
| on a <a>grid item</a> which is not a <a>scroll container</a> |
| * <var>body</var>'s <a>parent element</a>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible''. | ||
| * <var>body</var>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible''. | ||
| * <var>body</var>'s <a>parent element</a>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible'' nor ''overflow/clip''. | ||
| * <var>body</var>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible'' nor ''overflow/clip''. |
Collaborator
Author
|
Thanks. I also learned some grammar along the way (which vs that) |
fergald
pushed a commit
to fergald/csswg-drafts
that referenced
this pull request
May 7, 2018
[css-align][css-flexbox][css-grid][css-transforms-2][cssom-view] deal with overflow:clip Make sure that various specs correctly invoke either "overflow is not visible" or "is a scroll container" since these two are no longer equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that various specs correctly invoke either
"overflow is not visible" or "is a scroll container" since these two are
no longer equivalent.
This change is meant to be editorial prior to the introduction of 'overflow: clip', and to avoid the introduction of 'overflow:clip' to have undesirable normative effects.
This PR does not bother with maintained specs like css-box.