-
Notifications
You must be signed in to change notification settings - Fork 708
Deal with overflow:clip #2596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with overflow:clip #2596
Conversation
… with overflow:clip Make sure that various specs correctly invoke either "overflow is not visible" or "is a scroll container" since these two are no longer equivalent.
Requesting review: @tabatkins @fantasai @zcorpan |
Merging this should close #1971 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but please fix the grammatical errors before merging. :)
css-flexbox-1/Overview.bs
Outdated
@@ -905,9 +905,9 @@ Automatic Minimum Size of Flex Items</h3> | |||
|
|||
To provide a more reasonable default <a>minimum size</a> for <a>flex items</a>, | |||
the used value of a <a>main axis</a> <a>automatic minimum size</a> | |||
on a <a>flex item</a> whose 'overflow' is ''overflow/visible'' in the <a>main axis</a> | |||
on a <a>flex item</a> which is not a <a>scroll container</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/which/that/
css-grid-1/Overview.bs
Outdated
@@ -1238,7 +1238,7 @@ Automatic Minimum Size of Grid Items</h3> | |||
|
|||
To provide a more reasonable default <a>minimum size</a> for <a>grid items</a>, | |||
the used value of an <a>automatic minimum size</a> in a given axis | |||
on a <a>grid item</a> whose 'overflow' is ''overflow/visible'' in that same axis | |||
on a <a>grid item</a> which is not a <a>scroll container</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/which/that/
cssom-view-1/Overview.bs
Outdated
* <var>body</var>'s <a>parent element</a>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible''. | ||
* <var>body</var>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible''. | ||
* <var>body</var>'s <a>parent element</a>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible'' nor ''overflow/clip''. | ||
* <var>body</var>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible'' nor ''overflow/clip''. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/not/neither/g;
Thanks. I also learned some grammar along the way (which vs that) |
[css-align][css-flexbox][css-grid][css-transforms-2][cssom-view] deal with overflow:clip Make sure that various specs correctly invoke either "overflow is not visible" or "is a scroll container" since these two are no longer equivalent.
Make sure that various specs correctly invoke either
"overflow is not visible" or "is a scroll container" since these two are
no longer equivalent.
This change is meant to be editorial prior to the introduction of 'overflow: clip', and to avoid the introduction of 'overflow:clip' to have undesirable normative effects.
This PR does not bother with maintained specs like css-box.