Skip to content

Deal with overflow:clip #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2018
Merged

Deal with overflow:clip #2596

merged 4 commits into from
Apr 20, 2018

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Apr 20, 2018

Make sure that various specs correctly invoke either
"overflow is not visible" or "is a scroll container" since these two are
no longer equivalent.

This change is meant to be editorial prior to the introduction of 'overflow: clip', and to avoid the introduction of 'overflow:clip' to have undesirable normative effects.


This PR does not bother with maintained specs like css-box.

… with overflow:clip

Make sure that various specs correctly invoke either
"overflow is not visible" or "is a scroll container" since these two are
no longer equivalent.
@frivoal
Copy link
Collaborator Author

frivoal commented Apr 20, 2018

Requesting review: @tabatkins @fantasai @zcorpan

@frivoal
Copy link
Collaborator Author

frivoal commented Apr 20, 2018

Merging this should close #1971

Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but please fix the grammatical errors before merging. :)

@@ -905,9 +905,9 @@ Automatic Minimum Size of Flex Items</h3>

To provide a more reasonable default <a>minimum size</a> for <a>flex items</a>,
the used value of a <a>main axis</a> <a>automatic minimum size</a>
on a <a>flex item</a> whose 'overflow' is ''overflow/visible'' in the <a>main axis</a>
on a <a>flex item</a> which is not a <a>scroll container</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/which/that/

@@ -1238,7 +1238,7 @@ Automatic Minimum Size of Grid Items</h3>

To provide a more reasonable default <a>minimum size</a> for <a>grid items</a>,
the used value of an <a>automatic minimum size</a> in a given axis
on a <a>grid item</a> whose 'overflow' is ''overflow/visible'' in that same axis
on a <a>grid item</a> which is not a <a>scroll container</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/which/that/

* <var>body</var>'s <a>parent element</a>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible''.
* <var>body</var>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible''.
* <var>body</var>'s <a>parent element</a>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible'' nor ''overflow/clip''.
* <var>body</var>'s computed value of the 'overflow-x' or 'overflow-y' properties is not ''overflow/visible'' nor ''overflow/clip''.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/not/neither/g;

@fantasai fantasai removed the ready label Apr 20, 2018
@fantasai fantasai merged commit b69be9e into w3c:master Apr 20, 2018
@frivoal frivoal deleted the clip-fixup branch April 20, 2018 23:21
@frivoal
Copy link
Collaborator Author

frivoal commented Apr 20, 2018

Thanks. I also learned some grammar along the way (which vs that)

fergald pushed a commit to fergald/csswg-drafts that referenced this pull request May 7, 2018
[css-align][css-flexbox][css-grid][css-transforms-2][cssom-view] deal with overflow:clip

Make sure that various specs correctly invoke either "overflow is not visible" or "is a scroll container" since these two are no longer equivalent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants