Skip to content

Conversation

@SebastianZ
Copy link
Contributor

No description provided.

@fantasai
Copy link
Collaborator

fantasai commented Jul 6, 2016

While I appreciate the effort, this needs to wait on the CR update of Values and Units (which is currently blocked on calc serialization... which I might just drop for a quicker CR update if it isn't sorted out soon, but anyway, we're blocked on this atm). Would you prefer that we close the PR for now, or leave it open?

@SebastianZ
Copy link
Contributor Author

SebastianZ commented Jul 7, 2016

@tabatkins already merged #263, #264 and #265, which did the same for CSS Backgrounds, CSS Position and CSS Fonts.
If you feel it's too early to merge, I'd prefer to leave it open. And I'll adjust it if it cannot be merged without conflicts later. The same applies to #268 and #269.
If required, feel free to back out the changes merged by Tab and I'll create new PRs once the Values and Units CR is updated. (Just ping me then if I miss the CR update.)

Sebastian

@tabatkins
Copy link
Member

Nah, it's just that we're publishing a Grid CR update right now. We need to push a V&U update so that <length-percentage> is at least at WD level.

@SebastianZ
Copy link
Contributor Author

Nah, it's just that we're publishing a Grid CR update right now.

That "right now" obviously takes a bit. 😄

We need to push a V&U update so that <length-percentage> is at least at WD level.

The minutes of the telcon from 2016-08-03 don't include this dependency. Is the requirement to publish another V&U CR before Grid CR tracked somewhere?

Sebastian

@SebastianZ SebastianZ force-pushed the css-grid-length-percentage branch from cbb7f52 to 28887f0 Compare October 26, 2016 21:23
@SebastianZ
Copy link
Contributor Author

Rebased the patch. As the <*-percentage> values finally made it into the V&U CR, it should be ok to merge it now.

Sebastian

@tabatkins tabatkins merged commit afb6f66 into w3c:master Nov 22, 2016
@SebastianZ SebastianZ deleted the css-grid-length-percentage branch November 23, 2016 18:30
@SebastianZ
Copy link
Contributor Author

Thank you for merging this PR, Tab!

Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants