[css-fonts-4] Fix Web IDL syntax #2709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous Web IDL update only fixed the first error reported by Reffy: w3c@146c023#diff-efb4bfc382aa57898723c5208cfa0d4d A few other semi-colons were still missing. Also, the spec used the `MapClass` extended attribute, which no longer exists in Web IDL. The interface now uses a maplike declaration: https://heycam.github.io/webidl/#idl-maplike
litherum
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Web IDL update (146c023) only fixed the first syntax error reported by Reffy.
A few other semi-colons were still missing. Also, the spec used the
MapClassextended attribute, which no longer exists in Web IDL. TheCSSFontFeatureValuesMapinterface now uses a maplike declaration.