[css-transforms-2] Explicitly reset the temp matrix in matrix recomposition.#2713
Open
emilio wants to merge 1 commit into
Open
[css-transforms-2] Explicitly reset the temp matrix in matrix recomposition.#2713emilio wants to merge 1 commit into
emilio wants to merge 1 commit into
Conversation
…sition. The idea of the blocks (IIUC) are to reset `temp` to be an identity matrix in case it's been used before. However if only skew[0] and skew[2] are non-zero, this code didn't manage to accomplish it. Make it so that the reset is explicit after setting a matrix member instead of try to undo all other possible mutations that have happened before.
Contributor
|
If resetting is not the intention there still would be something wrong with the current code in the spec. Your change does seem to make sense but I’d like to look over it again first. |
Contributor
|
close-and-reopen to kick the ipr bot |
Contributor
|
@dirkschulze @emilio is this ancient PR still wanted? |
Collaborator
Author
|
I think so? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of the blocks (IIUC) are to reset
tempto be an identity matrix incase it's been used before.
However if only skew[0] and skew[2] are non-zero, this code didn't manage to
accomplish it.
Make it so that the reset is explicit after setting a matrix member instead of
try to undo all other possible mutations that have happened before.