-
Notifications
You must be signed in to change notification settings - Fork 756
[mediaqueries-3] Mention ASCII case-insensitivity, not only case-insensitivity. #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As that there's no effective difference between case insensitive and ASCII case insensitive in this case since there are no defined media features with non-ascii characters, I think this PR ends up just being editorial. Since updating a REC is relatively process heavy, I'm tempted to rejected it. It's not wrong, but it seems too little value for too much work. @atanassov @astearns @svgeesus, what do you think? |
|
I think it's not worth making the change to level 3 |
|
Sure, sounds fine, closing then. Thanks! |
|
There is a detectable difference between ASCII-case-insensitive and Unicode-case-insensitive. For example, should "HEİGHT" (with a dot on the capital I) be a valid media feature? The capital dotted I (İ) should lowercase to a standard ASCII lowercase i. |
|
Reopening based on that. |
|
This should just linkify "ASCII case-insensitive", as that's a well-defined term in Infra. |
True, although lobbing it into an erratum is pretty easy, if we decide to accept this. |
|
Please link |
881f7ca to
56b98b1
Compare
|
Done |
svgeesus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Now I need to list that as an erratum ... |
|
@svgeesus Should we make a test for that, and the update the MQ3 REC? Erratum are hard to read and easy to miss. I think the answer's yes, and if the process turns out to have too much friction to make this convenient, the process should be fixed and that gives me something to do on the AB. |
|
Also, if we're going to be errataing / republishing a REC, I think we should actually have a WG resolution on the change. @astearns @atanassov ? |
|
https://wpt.fyi/results/css/mediaqueries/mq-case-insensitive-001.html is already there and tests the case-insensitive / ascii-case-insensitive difference. We landed it as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1464091, and it passes in all browsers. So this is a bit of a no-brainer IMO, but sure, should be fine to have a resolution for this if you want :) |
Sure, I have no disagreement about the technical issue. But there are checks along the way to publishing things on TR, and I think leaving a clear trail of how we got there helps reduce friction. |
Yes, all errata should have tests (and all errata rolled into a new edition of a spec must have tests). |
Not that it's observable I think, since there are no defined media features with non-ascii characters, but...