Skip to content

Conversation

@emilio
Copy link
Collaborator

@emilio emilio commented May 31, 2018

Not that it's observable I think, since there are no defined media features with non-ascii characters, but...

@frivoal
Copy link
Collaborator

frivoal commented Jun 1, 2018

As that there's no effective difference between case insensitive and ASCII case insensitive in this case since there are no defined media features with non-ascii characters, I think this PR ends up just being editorial. Since updating a REC is relatively process heavy, I'm tempted to rejected it. It's not wrong, but it seems too little value for too much work.

@atanassov @astearns @svgeesus, what do you think?

@astearns
Copy link
Member

astearns commented Jun 1, 2018

I think it's not worth making the change to level 3

@emilio
Copy link
Collaborator Author

emilio commented Jun 1, 2018

Sure, sounds fine, closing then. Thanks!

@emilio emilio closed this Jun 1, 2018
@emilio emilio deleted the ascii-case-insensitive branch June 1, 2018 01:10
@dbaron
Copy link
Member

dbaron commented Jun 1, 2018

There is a detectable difference between ASCII-case-insensitive and Unicode-case-insensitive. For example, should "HEİGHT" (with a dot on the capital I) be a valid media feature? The capital dotted I (İ) should lowercase to a standard ASCII lowercase i.

@emilio emilio restored the ascii-case-insensitive branch June 1, 2018 08:21
@emilio
Copy link
Collaborator Author

emilio commented Jun 1, 2018

Reopening based on that.

@emilio emilio reopened this Jun 1, 2018
@tabatkins
Copy link
Member

This should just linkify "ASCII case-insensitive", as that's a well-defined term in Infra.

@svgeesus
Copy link
Contributor

Since updating a REC is relatively process heavy, I'm tempted to rejected it. It's not wrong, but it seems too little value for too much work.

True, although lobbing it into an erratum is pretty easy, if we decide to accept this.

@svgeesus
Copy link
Contributor

Please link ASCII case-insensitive as requested by @tabatkins

@emilio emilio force-pushed the ascii-case-insensitive branch from 881f7ca to 56b98b1 Compare December 10, 2018 22:12
@emilio
Copy link
Collaborator Author

emilio commented Dec 10, 2018

Done

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svgeesus svgeesus merged commit cb0e160 into w3c:master Dec 10, 2018
@svgeesus
Copy link
Contributor

Now I need to list that as an erratum ...

@svgeesus svgeesus self-assigned this Dec 10, 2018
@frivoal
Copy link
Collaborator

frivoal commented Dec 11, 2018

@svgeesus Should we make a test for that, and the update the MQ3 REC? Erratum are hard to read and easy to miss. I think the answer's yes, and if the process turns out to have too much friction to make this convenient, the process should be fixed and that gives me something to do on the AB.

@frivoal
Copy link
Collaborator

frivoal commented Dec 11, 2018

Also, if we're going to be errataing / republishing a REC, I think we should actually have a WG resolution on the change. @astearns @atanassov ?

@emilio emilio deleted the ascii-case-insensitive branch December 11, 2018 02:48
@emilio
Copy link
Collaborator Author

emilio commented Dec 11, 2018

https://wpt.fyi/results/css/mediaqueries/mq-case-insensitive-001.html is already there and tests the case-insensitive / ascii-case-insensitive difference.

We landed it as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1464091, and it passes in all browsers.

So this is a bit of a no-brainer IMO, but sure, should be fine to have a resolution for this if you want :)

@frivoal
Copy link
Collaborator

frivoal commented Dec 11, 2018

tests [...] passes in all browsers.
Great.

So this is a bit of a no-brainer IMO, but sure, should be fine to have a resolution for this if you want :)

Sure, I have no disagreement about the technical issue. But there are checks along the way to publishing things on TR, and I think leaving a clear trail of how we got there helps reduce friction.

@svgeesus
Copy link
Contributor

@svgeesus Should we make a test for that, and the update the MQ3 REC?

Yes, all errata should have tests (and all errata rolled into a new edition of a spec must have tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants