[css-logical-1] Add some concepts for logical properties for other specs to use #2922
Conversation
css-logical-1/Overview.bs
Outdated
| 'writing-mode', 'direction', and 'text-orientation'. | ||
|
|
||
| Each set of flow-relative properties and their parallel physical | ||
| properties are in the same <dfn export>logical property group</dfn>. |
There was a problem hiding this comment.
It's not clear to me which these groups are. Can it be made more explicit?
| form a <a>logical property group</a>, while 'margin-block-start', | ||
| 'margin-block-end', 'margin-inline-start', 'margin-inline-end', | ||
| 'margin-top', 'margin-right', 'margin-bottom', and 'margin-left' | ||
| form another. |
There was a problem hiding this comment.
What about shorthand properties like margin-block?
There was a problem hiding this comment.
Regarding the proposed use in #2924, it doesn't matter. Shorthand properties are expanded to longhands during parsing.
There was a problem hiding this comment.
Yes, but this should be properly defined independently of #2924. "Each set of flow-relative properties" seems to include shorthands, but they are not in the example. You can say "Each set of flow-relative longhand properties"
There was a problem hiding this comment.
Changed that according to your suggestion. Thanks.
|
FWIW I just reviewed this, and this looks fine to me |
|
OK, so, I think this needs some revision. For example, an example shouldn't be marked as a note, it should be marked as an example. :) But it's easier for me to just merge it and edit it than to ask for fiddly wording changes that are annoying to pass back and forth so gonna just do that... |
|
Thanks! |
|
Notes on changes made...
|
Specifically I'd like to reference them in cssom spec.