Skip to content

Conversation

@frivoal
Copy link
Collaborator

@frivoal frivoal commented Jul 28, 2018

Closes #285

@frivoal frivoal added the css-ui-4 Current Work label Jul 28, 2018
@frivoal frivoal requested a review from upsuper July 28, 2018 15:24
@frivoal
Copy link
Collaborator Author

frivoal commented Jul 28, 2018

This clarifies what is supposed to happen on form controls when they're in read-only mode.

As per #285 (comment), this does not attempt to prevent user-select: none or user-select: all on such things, but does make sure that user-select: auto and user-select: text do the same thing as user-select:contain.

We could have all values compute to contain, but allowing none and all seems useful and not particularly hard, if that's OK with implementers.

Copy link
Member

@upsuper upsuper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the general idea here, but I'm concerned about the ambiguity of the definition.

<li>
on <a>locked editable element</a>s
where the computed value is ''user-select/contain''
if the specified value was ''user-select/text'' or ''user-select/auto''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the handling of auto for this case is mentioned below, it can probably be removed here.

A <dfn>locked editable element</dfn> is
a normally <a href="https://www.w3.org/TR/html/sec-forms.html#mutable">mutable</a> form control with textual content,
when it is placed in a non mutable state,
such as a <{textarea}> with the <a href="https://html.spec.whatwg.org/multipage/input.html#the-readonly-attribute"><code>readonly</code></a> attribute.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that this definition is probably not clear enough, for example, it is unclear whether a disabled form control is a "locked editable element". I guess the ambiguity is from "normally mutable form control". Is a disabled form control considered normally mutable? Or is being disabled just a non-mutable state?

Maybe explicitly referencing readonly attribute rather than listing it as an example may help? Something like "a otherwise mutable form control ... when it is placed in a non-mutable state by readonly attribute".

Base automatically changed from master to main February 2, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css-ui-4 Current Work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants