8000 Update refs to the box model by xfq · Pull Request #3090 · w3c/csswg-drafts · GitHub
Skip to content

Update refs to the box model#3090

Merged
svgeesus merged 2 commits into
w3c:masterfrom
xfq:css-box-3
Sep 21, 2018
Merged

Update refs to the box model#3090
svgeesus merged 2 commits into
w3c:masterfrom
xfq:css-box-3

Conversation

@xfq
Copy link
Copy Markdown
Member

@xfq xfq commented Sep 10, 2018

Follow-up of #3078.

frivoal
frivoal reviewed Sep 10, 2018
View reviewed changes
Comment thread css-contain-1/Overview.bs
frivoal
frivoal reviewed Sep 10, 2018
View reviewed changes
Comment thread css-ui-3/Overview.bs
@xfq
Copy link
Copy Markdown
Member Author

xfq commented Sep 13, 2018

Fair enough, @frivoal. I pushed a commit to revert the changes to css-contain-1 & css-ui-3.

@frivoal
Copy link
Copy Markdown
Collaborator

frivoal commented Sep 13, 2018

The changes to other specs look good to me, but I'm not the editor. I suggest you wait a bit more to see if someone has an issue, and otherwise merge.

One side comment: your commit also removes a number of trailing spaces at the end of lines. Removing them is good, but it would make reviews easier to do that in a separate commit or pull request in the future.

@xfq
Copy link
Copy Markdown
Member Author

xfq commented Sep 13, 2018 •
edited
Loading

The changes to other specs look good to me, but I'm not the editor. I suggest you wait a bit more to see if someone has an issue, and otherwise merge.

Will do. Thank you!

One side comment: your commit also removes a number of trailing spaces at the end of lines. Removing them is good, but it would make reviews easier to do that in a separate commit or pull request in the future.

Agreed.

(For the reviewers: you can append ?w=1 to the URL to hide whitespace changes. Sorry for the inconvenience.)

svgeesus
svgeesus approved these changes Sep 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@svgeesus svgeesus merged commit ff375d2 into w3c:master Sep 21, 2018
@xfq xfq deleted the css-box-3 branch September 22, 2018 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frivoal frivoal frivoal left review comments

@svgeesus svgeesus svgeesus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xfq @frivoal @svgeesus