Skip to content

Conversation

@xfq
Copy link
Member

@xfq xfq commented Sep 10, 2018

Follow-up of #3078.

@xfq
Copy link
Member Author

xfq commented Sep 13, 2018

Fair enough, @frivoal. I pushed a commit to revert the changes to css-contain-1 & css-ui-3.

@frivoal
Copy link
Collaborator

frivoal commented Sep 13, 2018

The changes to other specs look good to me, but I'm not the editor. I suggest you wait a bit more to see if someone has an issue, and otherwise merge.

One side comment: your commit also removes a number of trailing spaces at the end of lines. Removing them is good, but it would make reviews easier to do that in a separate commit or pull request in the future.

@xfq
Copy link
Member Author

xfq commented Sep 13, 2018

The changes to other specs look good to me, but I'm not the editor. I suggest you wait a bit more to see if someone has an issue, and otherwise merge.

Will do. Thank you!

One side comment: your commit also removes a number of trailing spaces at the end of lines. Removing them is good, but it would make reviews easier to do that in a separate commit or pull request in the future.

Agreed.

(For the reviewers: you can append ?w=1 to the URL to hide whitespace changes. Sorry for the inconvenience.)

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@svgeesus svgeesus merged commit ff375d2 into w3c:master Sep 21, 2018
@xfq xfq deleted the css-box-3 branch September 22, 2018 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants