[css-transforms-2] Add definitions for transform list addition and accumulation #3141
Conversation
|
/cc @fantasai |
css-transforms-2/Overview.bs
Outdated
| which combine using <dfn>accumulation for one-based values</dfn> as follows: | ||
|
|
||
| <var ignore>V<sub>result</sub></var> = | ||
| <var ignore>V<sub>a</sub></var> + <var ignore>V<sub>b</sub></var> - 1 |
There was a problem hiding this comment.
These two lines are separated and indented in the source, but all this will do in the output is make them inline in a new paragraph. Was that intended?
Also, again with using <div algorithm>, and defining the input vars to your algorithm and then using them; that way you won't need to ignore them all.
(and note that you can use |V| instead of <var>V</var>, to make the var usage less intrusive.)
There was a problem hiding this comment.
This too is referencing the notation from css-values-4. I guess we should work out how to link it somehow?
Unfortunately |V<sub>result</sub>| doesn't parse as a variable so we have to use <var>V<sub>result</sub></var>.
There was a problem hiding this comment.
Ah, yes, markup will indeed disturb that. All the other variables can be done simpler. ^_^
There was a problem hiding this comment.
Oh, I missed the other variables. I tried switching m11 etc. to |m11| but then I got warnings about unreferenced variables. I found another reference to <var ignore>m11</var> in the doc and dropped the ignore attribute but it didn't fix it because I had scoped my m11 to the "transform list accumulation" algorithm.
I wonder if there's some way to make the "Mathematical Description of Transform Functions" section define these variables? They're currently defined in an image there.
|
I've addressed the review feedback I could, but I need guidance about how we should approach the variables. Does it makes sense to make them definitions in css-values-4? Or is there some other way to link to them there? |
…ions This text has now been improved and moved to CSS Transforms Level 2.
I couldn't work out how to fix the link errors to SVG 1.1's <animate> and <set> elements since SVG 1.1 and SVG Animation Elements don't appear to be indexed.
258f737 to
faf80fa
Compare
|
Ok, everything should be addressed except the nicer markup for I also added a separate commit to fix some link errors / warnings in the existing file. I wasn't able to fix the link errors to SVG |
|
@tabatkins review ping? |
No description provided.