Skip to content

[css-text-3] Add Japanese example for keep-all #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2018
Merged

[css-text-3] Add Japanese example for keep-all #3152

merged 2 commits into from
Oct 3, 2018

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Sep 26, 2018

No description provided.

@frivoal frivoal added the css-text-3 Current Work label Sep 26, 2018
@frivoal frivoal self-assigned this Sep 26, 2018
@frivoal frivoal requested a review from fantasai September 26, 2018 01:23
fantasai
fantasai requested changes Oct 3, 2018
View reviewed changes
Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a pre block to show the expected rendering, as the illustration is totally invalid if the property is not supported.

@frivoal
Copy link
Collaborator Author

frivoal commented Oct 3, 2018

Use a pre block to show the expected rendering

done.

@fantasai fantasai merged commit 8511b2b into w3c:master Oct 3, 2018
@frivoal frivoal deleted the keep-all-example branch April 25, 2019 06:19
@frivoal frivoal added the Testing Unnecessary Memory aid - issue doesn't require tests label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantasai fantasai fantasai requested changes

Assignees

@frivoal frivoal

Labels
css-text-3 Current Work Testing Unnecessary Memory aid - issue doesn't require tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frivoal @fantasai