Skip to content

[css-contain-1] Add bikeshed wpt info #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2018
Merged

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Sep 28, 2018

Adding the bikeshed wpt info for tests in the wpt test suite.

@tabatkins I think I'm doing this right, but I don't understand if this is safe to merge. If I understand correctly, any test added to wpt that isn't referenced here will generate a fatal error, and block the spec from being auto-regenerated on http://drafts.csswg.org/, which seems bad.

Generating a warning is totally useful, but I fatal error seems a problem. Am I misunderstanding something?

@frivoal frivoal self-assigned this Sep 28, 2018
@frivoal frivoal requested a review from tabatkins September 28, 2018 04:45
@rachelandrew
Copy link
Contributor

Just jumping in here as I am doing this for multicol at the moment, you can put a wpt-rest element in to scoop them up. That generates a warning to let you know. I think that's the right thing to do, partly commenting in case I'm doing the wrong thing as then I'll know too :)

https://tabatkins.github.io/bikeshed/#elementdef-wpt-rest

@frivoal
Copy link
Collaborator Author

frivoal commented Sep 28, 2018

hmmm. <wpt-rest> generates a fatal error if there aren't more tests, so that doesn't seem to help either.

@tabatkins
Copy link
Member

Fatal errors don't stop auto-publishing on csswg.org. You can see several specs with red status on https://drafts.csswg.org/ ^_^

Copy link
Member

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to current WPT, you're missing:

  • css/css-contain/contain-layout-button-001.html
  • css/css-contain/contain-layout-flexbox-001.html
  • css/css-contain/contain-layout-grid-001.html

@frivoal
Copy link
Collaborator Author

frivoal commented Sep 29, 2018

According to current WPT, you're missing: [...]

Damn, these were added since yesterday!

Fatal errors don't stop auto-publishing on csswg.org.

aha. I was running bikeshed spec -f and that didn't work, but that's because the correct invocation is bikeshed -f spec

@frivoal frivoal merged commit d7115f4 into w3c:master Sep 29, 2018
@frivoal frivoal deleted the contain-bikeshed-wpt branch June 5, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants