[css-transforms-1] Specify the "pad, interpolate prefix, then smoosh" interpolation behavior #3215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 19, 2018
…or transform lists; r=hiro As discussed in: w3c/csswg-drafts#927 with tentative spec text: w3c/csswg-drafts#3215 Depends on D9184 Differential Revision: https://phabricator.services.mozilla.com/D9185 --HG-- extra : moz-landing-system : lando
Contributor
Author
|
Anyone care to review this? We've already landed it in Firefox and upstreamed the tests to wpt. |
Contributor
Author
|
Review ping? @tabatkins? |
Contributor
|
@birtles I will review it on Monday. I’d like to look at it before it lands. |
emilio
pushed a commit
to emilio/servo
that referenced
this pull request
Oct 28, 2018
…sform lists. As discussed in: w3c/csswg-drafts#927 with tentative spec text: w3c/csswg-drafts#3215 Differential Revision: https://phabricator.services.mozilla.com/D9185
tabatkins
approved these changes
Nov 1, 2018
| while the remainder of each list-- | ||
| ''rotate(90deg) translate(20px)'' and ''translate(10px) rotate(270deg)''-- | ||
| will first be converted to equivalent 4x4 matrices | ||
| and then interpolated as described in [[#matrix-interpolation]]. |
Member
There was a problem hiding this comment.
This example, if I'm thinking correctly, gives the same result whether you use whole-property matrix interpolation or this smarter interpolation. I recommend providing an example that showcases the differences between the two; an obvious example would be having the common prefix be a rotate(0deg) and rotate(360deg), which is hugely different.
Then you can also have a small note in this that the spec previously used whole-property matrix interpolation, which would have a different effect.
Contributor
Author
There was a problem hiding this comment.
Yeah, good idea. I have no idea why I chose the values I did.
Member
|
Approved, but I have one suggestion for improving an example. |
… interpolation behavior This fixes w3c#927.
719d477 to
81d7081
Compare
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…or transform lists; r=hiro As discussed in: w3c/csswg-drafts#927 with tentative spec text: w3c/csswg-drafts#3215 Depends on D9184 Differential Revision: https://phabricator.services.mozilla.com/D9185 UltraBlame original commit: 660b4ee6c9133fb2fb9fee9d70cf0e8d9b04051a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…or transform lists; r=hiro As discussed in: w3c/csswg-drafts#927 with tentative spec text: w3c/csswg-drafts#3215 Depends on D9184 Differential Revision: https://phabricator.services.mozilla.com/D9185 UltraBlame original commit: 660b4ee6c9133fb2fb9fee9d70cf0e8d9b04051a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…or transform lists; r=hiro As discussed in: w3c/csswg-drafts#927 with tentative spec text: w3c/csswg-drafts#3215 Depends on D9184 Differential Revision: https://phabricator.services.mozilla.com/D9185 UltraBlame original commit: 660b4ee6c9133fb2fb9fee9d70cf0e8d9b04051a
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…or transform lists; r=hiro As discussed in: w3c/csswg-drafts#927 with tentative spec text: w3c/csswg-drafts#3215 Depends on D9184 Differential Revision: https://phabricator.services.mozilla.com/D9185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #927.