[css-device-adapt] Adds motivating scenarios and rewording of intro #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </body> | ||
| </html> | ||
| </pre> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
Same comment as the intro. Maybe this spec should normatively define the meta tag. But for now it doesn't, and I think we should resolve on that before adding examples that rely on it.
Collaborator
|
Good rewording on the intro, but I kind of disagree with putting examples about the meta viewport and calling it out in the intro while the spec doesn't informatively define it. It probably should, but for now it doesn't. (see comments on the diff). |
css-device-adapt/Overview.bs
Outdated
| <head> | ||
| <title>My Site</title> | ||
| <style> | ||
| @viewport { width: device-width; } |
Collaborator
There was a problem hiding this comment.
should be @viewport { width: auto; }. width: device-width was removed from the spec quite a while back.
Collaborator
|
Intro looks good now. There's a minor fix to add in the first example, and then we're good. |
…nsive and partially responsive examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #326
Intro reworded to discuss more of the "why" -- why current default behavior exists and why authors would want to opt-out. Added 2 scenarios -- one for fully responsive using viewport and one partially responsive using @Viewport and @media. The examples use the current syntax for now, if/when syntax changes are made they can be updated at that time.