-
Notifications
You must be signed in to change notification settings - Fork 756
Florian/contain and clip #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -197,8 +197,12 @@ Paint Containment</h3> | |
|
|
||
| Giving an element <dfn export>paint containment</dfn> has the following effects: | ||
|
|
||
| 1. The contents of the element must be clipped to the element's content box. | ||
| This includes both the paint of the descendants and their geometry (similar to overflow). | ||
| 1. As specified in [[!CSS-OVERFLOW-3]], | ||
| the computed value the 'overflow-x' and 'overflow-y' is changed to ''overflow/clip'' | ||
| if it would otherwise have been ''overflow/visible''. | ||
| <span class=note>This means that regardless of the specified value of 'overflow', | ||
| the contents of the element is clipped to the element's content box, | ||
| including both the paint of the descendants and their geometry</span> | ||
| 2. The element must act as a containing block for absolutely positioned and fixed positioned descendants. | ||
| 3. The element must be a <a>formatting context</a>. | ||
|
|
||
|
|
@@ -208,7 +212,8 @@ Paint Containment</h3> | |
| the UA can directly skip trying to paint its contents, | ||
| as they're guaranteed to be off-screen/obscured as well. | ||
|
|
||
| 2. If the containing element is ''overflow:visible'', | ||
| 2. If the containing element would have been ''overflow:visible'', | ||
| it becomes ''overflow:clip'' and | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line sounds like normative instructions; I'd prefer a parenthetical like (but is now overflow:clip due to paint containment), or something more direct, like "If the containing element's overflow has been changed to 'clip' (because it was originally visible), ..." |
||
| the UA can reserve "canvas" space for the element exactly the element's size. | ||
| (In similar, scrollable, situations, like ''overflow: hidden'', | ||
| it's possible to scroll to the currently-clipped content, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer "If the computed value of overflow-x or overflow-y would otherwise have been 'visible', it must instead compute to 'clip'. [[!CSS-OVERFLOW-3]]"