Migrate spatial navigation #3324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename spatNavSearchInside() to selectBestCandidateFromEdge - Modify spatNavSearch to match with the spec - Add more comments about the functions
Polyfill spatnav steps update
filteredCandidates() is for: - Get rid of the starting point from the focusables - Get rid of the elements which aren't in the direction from the focusables This is related to WICG/spatial-navigation#62
This function won't be used anymore.
- Add comments
Don't duplicate information found in the specification, and instead focus on what the polyfill itself is, how to use it, and what its status is.
- Considers the case that when the starting point is a position. ref: https://wicg.github.io/spatial-navigation/#spatial-navigation-steps (step 3)
Rewrite the Polyfill's readme
Add the polyfill names for getSpatnavContainer() and focusableAreas()
- Match Element.focusableAreas with the syntax in Spec - The function takes an option (visible / all) as a parameter - Match Element.getSpatnavContainer with the syntax in Spec - Get rid of findCandidates function which isn't used. - The same feature is supported by Element.focusableAreas
Polyfill spatnav step bug fix
- Fix indentation - Use LF instead of CRLF - Use const variables - etc
- Use LF instead of CRLF - Use const variables - Add missing semi-colons - etc
…oint Polyfill handling starting point
Previously, the polyfill supported the feature of spatnav container with specifying the class. But this changes allow to use CSS custom property for supporting the same feature.
Add the detailed comments about functions.
This indicates the release version of spatnav polyfill. This will be referenced by enact framework.
…perty Polyfill spatnav contain property
Update ReadME file
- Explain how to set the option of using standard name - focusNavigationHeuristics() which calls the polyfill takes the option
Modify importing the polyfill for the test files
Test cases about the spatial navigation on the grid-like layout. Those are aimed to - Experiment the proper result of the distance function - Investigate the reasonable heuristic spatial navigation behavior on the grid-like layout.
Test case about the heuristic spatial navigation behavior for a transformed element.
Test case about the heuristic spatial navigation behavior of the fragmented elements.
These are a bit special, since they're not actually testing the spec, but rather some UX expectations. Move the tests to a dedicated subdirectory clearly documented to be for UX testing rather than for spec testing.
Minor edit to fix some small issues with the markup: * <body> is optional * <script> is not allowed outside of body * stray spaces at the end of lines are bad
Test cases about the distance function of the spatial navigation
Move the files that should still exist after migration to the csswg to a subdirectory, and delete the rest.
These should point to a different place now that spatnav lives off in the csswg’s repository rather than in WICG.
This import merges the history of the two repositories.
This is a csswg spec now, update metadata accordingly
72b3ebf to
1a495f7
Compare
|
When merging this, WICG/spatial-navigation#136 should be merged as well. |
|
Btw, the resolution to do this is over there: https://w3.logbot.info/css/20181023#c451857 |
astearns
approved these changes
Nov 15, 2018
jihyerish
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the spatial navigation spec from WICG, including the whole git history, but removing irrelevant files.