Skip to content

[css-containment] Fix layout containment and fragmentainer interaction #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2015
Merged

[css-containment] Fix layout containment and fragmentainer interaction #34

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ce37eb
[css-containment] Fix layout containment and fragmentainer interaction
frivoal Jul 7, 2015
29c0b70
[css-containment] Fixup based on code review.
frivoal Jul 7, 2015
f88fc8c
[css-containment] Remove explicit spec links after fixing that spec
frivoal Jul 7, 2015
54d6873
[css-containment] Use fully qualified names
frivoal Jul 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[css-containment] Fixup based on code review.
  • Loading branch information
@frivoal
frivoal committed Jul 7, 2015
commit 29c0b7004eccd55916ac1b870fd1a86b7a0c1a4e
4 changes: 2 additions & 2 deletions css-containment/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,12 @@ Layout Containment</h3>
then they are not generated.
If they would exist regardless,
they remain part of the <a>fragmentation context</a>,
but do no receive any content from the <a>fragmented flow</a>.
but do not receive any content from the <a>fragmented flow</a>.

Specifically:
- <a spec=css-regions>CSS Regions</a> following the one which traps the content
Copy link
Member

@tabatkins tabatkins Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually need the spec='' attribute here? It looks like there's only two refs, one from the TR and one from the ED of the Regions spec.

Copy link
Collaborator Author

@frivoal frivoal Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bikeshed complains if you don't. I think they're not exported.

Copy link
Member

@tabatkins tabatkins Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you know what to do. (Export those terms! You can fix the database yourself!)

Copy link
Collaborator Author

@frivoal frivoal Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I can, but I don't know how to. Where is TFM for that, so that I can R it?

Copy link
Member

@tabatkins tabatkins Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/tabatkins/bikeshed/blob/master/docs/definitions-autolinks.md#exporting-definitions

Shorter answer: Add an export boolean attribute to all your "dfn" type definitions (the ones without an explicit type otherwise) that you want other specs to be able to link to. (That is, unless they're an internal definition you just have for use within the spec itself, export it.)

Copy link
Collaborator Author

@frivoal frivoal Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I actually knew that one, but assumed based on file extension .src.html that css-regions was not under bikeshed, and then I didn't know. But it is, so I'll fix this. How often is the database refreshed once I've done this?

Copy link
Member

@plinss plinss Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linking database is managed by Shepherd, and it parses all the CSS specs, not just those produced by Bikeshed (though the other specs may or may not have their <dfn>s marked up to be recognized properly). The spec database for drafts is updated within minutes after a push. Specs on /TR get updated at least once per day (midnight pacific time).

Copy link
Collaborator Author

@frivoal frivoal Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know the update is a fast one. As for figuring out what to do on non bikeshed specs... Let's just bikeshed them all.

are still considered part of the <a spec=css-regions>region chain</a>
as returned by the {{getRegions()}} method
as returned by the {{NamedFlow/getRegions()}} method
of the {{NamedFlow}} interface.
- the {{regionOverset}} attribute of the {{Region}} interface
of the region which traps the content
Expand Down