Skip to content

Conversation

@atotic
Copy link
Contributor

@atotic atotic commented Dec 8, 2018

[resize-observer-1] Update algorithms with new boxes

A large pull request, algorithm redo touched everything.

The main work was modifying algorithms to work with multiple boxes. This work should be complete. I assumed RO is only observing 1 box at a time, as discussed in #3329.

Minor work included:

  • fixing some of the spec bugs that were opened by domenic in the old repo.
  • switching from contentRect to borderBoxSize in examples, no need to showcase old API.

One last large remaining problem is ResizeObservation. It should not be an idl interface, but a bag of slots and algorithms. I'll do this next week.

I am not very proficient with bikeshed, especially references and slots. There is probably a lot of room for cleanup by an expert.

@atotic
Copy link
Contributor Author

atotic commented Dec 8, 2018

I've just connected my w3c account to github.

@gregwhitworth gregwhitworth merged commit 8eb7835 into w3c:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants