Skip to content

[css-transitions] Add ontransitionend global event handler #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2016

Conversation

birtles
Copy link
Contributor

@birtles birtles commented Jul 27, 2016

No description provided.

@birtles
Copy link
Contributor Author

birtles commented Jul 27, 2016

This updates CSS Transitions in the same way we updated CSS Animations to have these global event handlers.

Mozilla bug 911987 contains most of the history for this. Basically I proposed adding them back at TPAC 2015 but @grorg initially seemed hesitant. Then in the F2F in Feb 2016, @grorg (and a few other Apple folk who were in the room) commented that they won't be dropping support for these. As a result we should just go ahead and add them like we did for CSS Animations.

Note that as with CSS Animations I've made this include both content attributes and IDL attributes although in my testing I notice that only Safari supports the IDL attributes (Chrome does only the content attributes). It seems more consistent, however, to support both which is what this pull request specifies.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 8, 2016
…ers. r=masayuki,smaug

This event handler is defined CSS-Animation and CSS-Transition.
https://drafts.csswg.org/css-animations-1/#event-animationevent
w3c/csswg-drafts#344

MozReview-Commit-ID: ARgsibd7wST

--HG--
extra : rebase_source : 7b4f366a8661508185d60ead9ce68fb234959577
xeonchen pushed a commit to xeonchen/gecko-cinnabar that referenced this pull request Aug 8, 2016
…ers. r=masayuki,smaug

This event handler is defined CSS-Animation and CSS-Transition.
https://drafts.csswg.org/css-animations-1/#event-animationevent
w3c/csswg-drafts#344

MozReview-Commit-ID: ARgsibd7wST
@syncbot syncbot merged commit 1c6991f into master Aug 15, 2016
@tabatkins tabatkins removed the ready label Aug 15, 2016
@plinss
Copy link
Member

plinss commented Aug 15, 2016

Ack, sorry I probably merged this prematurely. I saw the branch in the hg repo and forgot to check for an outstanding PR.

In the future, please submit PRs from a personal repo instead of branches in the main repo. When in the main repo they get copied over to hg and we generally try to keep branches out of there.

@birtles
Copy link
Contributor Author

birtles commented Aug 16, 2016

I think this is probably fine to merge (and was just going to do it anyway rather than let it rot). I'll try to use a personal repo in future.

@plinss plinss deleted the birtles/add-ontransitionend-handler branch August 2, 2017 12:39
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Sep 30, 2019
…ers. r=masayuki,smaug

This event handler is defined CSS-Animation and CSS-Transition.
https://drafts.csswg.org/css-animations-1/#event-animationevent
w3c/csswg-drafts#344

MozReview-Commit-ID: ARgsibd7wST

UltraBlame original commit: 42b9cd44c5462162e563a01ac460c703d811dcae
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 30, 2019
…ers. r=masayuki,smaug

This event handler is defined CSS-Animation and CSS-Transition.
https://drafts.csswg.org/css-animations-1/#event-animationevent
w3c/csswg-drafts#344

MozReview-Commit-ID: ARgsibd7wST

UltraBlame original commit: 42b9cd44c5462162e563a01ac460c703d811dcae
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Sep 30, 2019
…ers. r=masayuki,smaug

This event handler is defined CSS-Animation and CSS-Transition.
https://drafts.csswg.org/css-animations-1/#event-animationevent
w3c/csswg-drafts#344

MozReview-Commit-ID: ARgsibd7wST

UltraBlame original commit: 42b9cd44c5462162e563a01ac460c703d811dcae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-transitions-1 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants