-
Notifications
You must be signed in to change notification settings - Fork 715
[css-transitions] Add ontransitionend global event handler #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This updates CSS Transitions in the same way we updated CSS Animations to have these global event handlers. Mozilla bug 911987 contains most of the history for this. Basically I proposed adding them back at TPAC 2015 but @grorg initially seemed hesitant. Then in the F2F in Feb 2016, @grorg (and a few other Apple folk who were in the room) commented that they won't be dropping support for these. As a result we should just go ahead and add them like we did for CSS Animations. Note that as with CSS Animations I've made this include both content attributes and IDL attributes although in my testing I notice that only Safari supports the IDL attributes (Chrome does only the content attributes). It seems more consistent, however, to support both which is what this pull request specifies. |
…ers. r=masayuki,smaug This event handler is defined CSS-Animation and CSS-Transition. https://drafts.csswg.org/css-animations-1/#event-animationevent w3c/csswg-drafts#344 MozReview-Commit-ID: ARgsibd7wST --HG-- extra : rebase_source : 7b4f366a8661508185d60ead9ce68fb234959577
…ers. r=masayuki,smaug This event handler is defined CSS-Animation and CSS-Transition. https://drafts.csswg.org/css-animations-1/#event-animationevent w3c/csswg-drafts#344 MozReview-Commit-ID: ARgsibd7wST
Ack, sorry I probably merged this prematurely. I saw the branch in the hg repo and forgot to check for an outstanding PR. In the future, please submit PRs from a personal repo instead of branches in the main repo. When in the main repo they get copied over to hg and we generally try to keep branches out of there. |
I think this is probably fine to merge (and was just going to do it anyway rather than let it rot). I'll try to use a personal repo in future. |
…ers. r=masayuki,smaug This event handler is defined CSS-Animation and CSS-Transition. https://drafts.csswg.org/css-animations-1/#event-animationevent w3c/csswg-drafts#344 MozReview-Commit-ID: ARgsibd7wST UltraBlame original commit: 42b9cd44c5462162e563a01ac460c703d811dcae
…ers. r=masayuki,smaug This event handler is defined CSS-Animation and CSS-Transition. https://drafts.csswg.org/css-animations-1/#event-animationevent w3c/csswg-drafts#344 MozReview-Commit-ID: ARgsibd7wST UltraBlame original commit: 42b9cd44c5462162e563a01ac460c703d811dcae
…ers. r=masayuki,smaug This event handler is defined CSS-Animation and CSS-Transition. https://drafts.csswg.org/css-animations-1/#event-animationevent w3c/csswg-drafts#344 MozReview-Commit-ID: ARgsibd7wST UltraBlame original commit: 42b9cd44c5462162e563a01ac460c703d811dcae
No description provided.