Skip to content

[css-images-4] Fix gradient color stop syntax #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

AmeliaBR
Copy link
Contributor

Closes #1334

I'm pretty sure this was the only change required. Not sure why I didn't make a PR at the time I filed the issue, but I guess I was busy…

Closes #1334

I'm pretty sure this was the only change required. Not sure why I didn't make a PR at the time I filed the issue, but I guess I was busy…
@fantasai
Copy link
Collaborator

While we're here... why is the color and length reorderable in Level 4? There was a fixed order in Level 3, was that a change we decided to make or an error in the spec?

@AmeliaBR
Copy link
Contributor Author

@fantasai That's a good question. I just tested it in Chrome, Edge, and Firefox, and none support the length value before the color.

The Git blame isn't helping me find a reason, either. The && syntax goes back to the first commit for Images 4.

As an author, I wouldn't mind having the extra flexibility. I've made the mistake of writing it in the wrong order & then having to debug why my gradient wasn't showing up.

But we'd need commitments to actually implement it — maybe at the same time as implementing the two-value syntax? But then we'd need to discuss whether blue, 20px green 30px, blue is a valid two-value form.

So maybe that's a separate issue?

@tabatkins tabatkins merged commit 8937527 into master Apr 15, 2019
@plinss plinss deleted the AmeliaBR-fix-1334 branch June 14, 2019 20:29
@syncbot syncbot restored the AmeliaBR-fix-1334 branch June 14, 2019 20:44
@plinss plinss deleted the AmeliaBR-fix-1334 branch June 14, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-images-4] Gradient color stop syntax is incorrect
4 participants