[css-text-decor-4] typo in text-decoration-skip-ink property name #3789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like 70e40c9 introduced the `text-decoration-skip-ink` property, but kept the example from the previous `text-decoration-skip` one.
Contributor
Author
|
Aformentioned commit was from @kojiishi |
Member
|
Marked as non substantive for IPR from ash-nazg. |
Contributor
Author
|
@dontcallmedom sorry, I'm not used to PRs here, should I have open an issue instead? |
Member
|
@nhoizey no worry at all, your pull request looks more than appropriate (although I'll leave it to the editors to do the real assessment :) I was mostly using one of our tools to indicate your pull request is acceptable from an IPR perspective |
Contributor
Author
|
@dontcallmedom ok, thanks! |
Contributor
Author
|
@kojiishi you're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like 70e40c9 introduced the
text-decoration-skip-inkproperty, but kept the example from the previoustext-decoration-skipone.