Tweaks and fixes to css-nav-1 #3808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://rhodesmill.org/brandon/2012/one-sentence-per-line/ for rationale on line breaking
inert as a concept exists in the HTML spec, but it is not accessible to authors, just some internal logic. inert as an attribute is (for now) only defined in a WICG explainer / polyfill. Since we're talking about the attribute, that is where we need to link.
…vigation-action property into account
3bffd38 to
ad7941c
Compare
jihyerish
reviewed
Apr 5, 2019
jihyerish
requested changes
Apr 5, 2019
ad7941c to
c3ad240
Compare
c3ad240 to
b19e62c
Compare
jihyerish
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #3732, #3755, and #3795.
It fixes a range of grammatical and editorial issues, and clarifies some ambiguities.