Skip to content

[css-values-3] link to a test#3823

Merged
frivoal merged 2 commits into
w3c:masterfrom
TalbotG:wpt-test
Apr 13, 2019
Merged

[css-values-3] link to a test#3823
frivoal merged 2 commits into
w3c:masterfrom
TalbotG:wpt-test

Conversation

@TalbotG
Copy link
Copy Markdown
Collaborator

@TalbotG TalbotG commented Apr 12, 2019

No description provided.

@dontcallmedom
Copy link
Copy Markdown
Member

Marked as non substantive for IPR from ash-nazg.

@ewilligers
Copy link
Copy Markdown
Contributor

Why not use the same approach as css-contain-1/css-flexbox-1/css-multicol-1?
They use WPT Path Prefix: and don't have WPT Display: inline.

@frivoal
Copy link
Copy Markdown
Collaborator

frivoal commented Apr 13, 2019

I was with @TalbotG when making this commit. WPT Display: inline was committed accidentally, we only meant to use it locally for testing. Sorry about that.

As for WPT Path Prefix: it triggers warnings / errors when there are test files in the directory you point to that you have not yet added to the spec. That's useful when you're done adding all / most tests and want to be informed about what's missing and what's just been added, but until then, it's mostly noise.

@frivoal frivoal merged commit 367f02c into w3c:master Apr 13, 2019
@TalbotG TalbotG deleted the wpt-test branch June 26, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants