-
Notifications
You must be signed in to change notification settings - Fork 715
[css-size-adjust] text-size-adjust is non-negative #3891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-size-adjust] text-size-adjust is non-negative #3891
Conversation
Like other sizing properties, text-size-adjust does not accept negative values.
Note also that in Firefox and Blink, 'none' computes to '100%'. Perhaps the spec should change |
How are you determining this? I don't think Firefox supports |
My mistake. I guess I made the mistake because a test passes in Firefox, but that would be because Firefox doesn't support the property, so test_computed_value succeeds immediately. |
Lack of support causing a test to pass means the test is written badly - test_computed_value() should fail or throw in that case. |
@dbaron please review |
@tantek please review. This avoids the warning
and forbids negative values. Note the browsers already reject negative values: |
@litherum please review. |
Like other sizing properties, text-size-adjust does not
accept negative values.