Skip to content

[css-size-adjust] text-size-adjust is non-negative #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2019

Conversation

ewilligers
Copy link
Contributor

Like other sizing properties, text-size-adjust does not
accept negative values.

Like other sizing properties, text-size-adjust does not
accept negative values.
@ewilligers
Copy link
Contributor Author

Note also that in Firefox and Blink, 'none' computes to '100%'.

Perhaps the spec should change
Computed value: specfied keyword or percentage
to
Computed value: specfied percentage, or 'auto'

@emilio
Copy link
Collaborator

emilio commented May 6, 2019

Note also that in Firefox and Blink, 'none' computes to '100%'.

How are you determining this? I don't think Firefox supports text-size-adjust: <percentage> to begin with.

@ewilligers
Copy link
Contributor Author

My mistake. I guess I made the mistake because a test passes in Firefox, but that would be because Firefox doesn't support the property, so test_computed_value succeeds immediately.

@tabatkins
Copy link
Member

Lack of support causing a test to pass means the test is written badly - test_computed_value() should fail or throw in that case.

@ewilligers
Copy link
Contributor Author

Lack of support causing a test to pass means the test is written badly - test_computed_value() should fail or throw in that case.

Test now changed: chromium / WPT

@ewilligers
Copy link
Contributor Author

@dbaron please review

@ewilligers
Copy link
Contributor Author

ewilligers commented Aug 10, 2019

@tantek please review.

This avoids the warning

LINE ~69: The biblio refs [[CSS2]] and [[CSS21]] are both aliases of the same base reference [[CSS2]]. Please choose one name and use it consistently.

and forbids negative values. Note the browsers already reject negative values:
https://wpt.fyi/results/css/css-size-adjust/parsing/text-size-adjust-invalid.html?label=master&label=experimental

@ewilligers
Copy link
Contributor Author

@litherum please review.
WPTs exist for valid non-negative and invalid negative percentages.

@tabatkins tabatkins merged commit 30e328c into w3c:master Oct 29, 2019
@ewilligers ewilligers deleted the text-size-adjust-non-negative branch October 29, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants