Skip to content

Conversation

@birtles
Copy link
Contributor

@birtles birtles commented May 9, 2019

No description provided.

@birtles birtles self-assigned this May 9, 2019
Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this. I really appreciate the inclusion of 'ways you should actually do this' as well.

I wonder if we could get something added to https://developer.mozilla.org/en-US/docs/Web/API/EffectTiming/fill as well?

@birtles
Copy link
Contributor Author

birtles commented May 9, 2019

I wonder if we could get something added to https://developer.mozilla.org/en-US/docs/Web/API/EffectTiming/fill as well?

Sure! Will do. (I'll merge this first though so I can link to it.)

Also, I'm sure you're aware but just in case, MDN is publicly editable (you can login with GitHub) so feel free to edit away if you notice anything amiss.

@birtles birtles merged commit bebe3a0 into w3c:master May 9, 2019
@birtles birtles deleted the fill-advisement branch May 9, 2019 23:48
@birtles
Copy link
Contributor Author

birtles commented May 10, 2019

@stephenmcgruer
Copy link
Contributor

Also, I'm sure you're aware but just in case, MDN is publicly editable (you can login with GitHub) so feel free to edit away if you notice anything amiss.

I was not aware! Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants