Skip to content

Conversation

@birtles
Copy link
Contributor

@birtles birtles commented May 9, 2019

This fixes #2058.

@birtles birtles self-assigned this May 9, 2019
@birtles birtles merged commit cf3a00e into w3c:master May 11, 2019
@annevk
Copy link
Member

annevk commented May 11, 2019

So the idea is to not tackle shadow roots at all? Will you add tests to ensure nothing from shadow roots is returned?

@birtles
Copy link
Contributor Author

birtles commented May 11, 2019

So the idea is to not tackle shadow roots at all? Will you add tests to ensure nothing from shadow roots is returned?

Right. Yes, I need to update the implementation in Firefox to match the spec terms and I plan to add WPT at that point. I'll make sure to add one for shadow roots at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[web-animations-1] Add parameter to getAnimations for getting animations in descendants too

3 participants