Skip to content

[css-ui] Restrict appearance: button more #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented May 24, 2019

Per web compat analysis [1], the button value can be restricted to

  • a
  • button
  • input type=button/reset/submit
  • drop-down box select

Part of #3024

Tests: TODO

[1] #3024 (comment)


cc @tkent-google @foolip @MatsPalmgren @emilio @jwatt

Per web compat analysis [1], the `button` value can be restricted to

* `a`
* `button`
* `input type=button/reset/submit`
* drop-down box `select`

Part of w3c#3024

Tests: TODO

[1] w3c#3024 (comment)
@emilio
Copy link
Collaborator

emilio commented May 24, 2019

How does this restriction work, is it at used value time? (looks like it from the spec text)

@zcorpan
Copy link
Member Author

zcorpan commented May 25, 2019

Yes. Keywords don't resolve/compute to other keywords, just "act as if".

@zcorpan zcorpan requested a review from frivoal June 20, 2019 00:27
@frivoal
Copy link
Collaborator

frivoal commented Dec 29, 2019

Looks good to me, but for one thing: I am a little surprised there's not web-compat need for button to have an effect on arbitrary divs. Did the compat study look include plain (non replaced, non-control) elements in "others" that and conclude it was fine, or was this left out?

@frivoal frivoal self-assigned this Dec 29, 2019
@zcorpan
Copy link
Member Author

zcorpan commented Jan 9, 2020

I think "others" included any element.

@tkent-google which elements does Chromium currently allow to have button appearance?

@tkent-google
Copy link
Contributor

I think "others" included any element.

@tkent-google which elements does Chromium currently allow to have button appearance?

Chrome 79 stable: button works with arbitrary elements except for <select> and <a>. We haven't received significant site-compatibility issues, and I think we can continue to exclude <select> and <a>.

Chrome 80 beta: button will work only with <button> and <input type=button/color/reset/submit>. It's still in Beta. We don't know whether wen can keep this behavior or not yet.

@frivoal
Copy link
Collaborator

frivoal commented Jul 14, 2020

The discussion has moved on since this PR, and #5174 has the latest on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-ui-4 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants