[css-overflow-3] #3779 Do not propagate overflow from boxless elements. #4148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frivoal
requested changes
Jul 26, 2019
Collaborator
frivoal
left a comment
There was a problem hiding this comment.
Thanks for the patch. Just few clarifications, and it'll be good to merge.
Co-Authored-By: Florian Rivoal <git@florian.rivoal.net>
Co-Authored-By: Florian Rivoal <git@florian.rivoal.net>
frivoal
approved these changes
Jul 30, 2019
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 30, 2019
PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 31, 2019
PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682679}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 31, 2019
PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682679}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 31, 2019
PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682679}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 5, 2019
… spec edit., a=testonly Automatic update from web-platform-tests Overflow tests no longer tentative after spec edit. PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682679} -- wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821 wpt-pr: 18185 --HG-- rename : testing/web-platform/tests/css/css-overflow/overflow-body-propagation-001.tentative.html => testing/web-platform/tests/css/css-overflow/overflow-body-propagation-001.html rename : testing/web-platform/tests/css/css-overflow/overflow-body-propagation-002.tentative.html => testing/web-platform/tests/css/css-overflow/overflow-body-propagation-002.html rename : testing/web-platform/tests/css/css-overflow/overflow-body-propagation-003.tentative.html => testing/web-platform/tests/css/css-overflow/overflow-body-propagation-003.html rename : testing/web-platform/tests/css/css-overflow/overflow-body-propagation-004.tentative.html => testing/web-platform/tests/css/css-overflow/overflow-body-propagation-004.html
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Aug 6, 2019
… spec edit., a=testonly Automatic update from web-platform-tests Overflow tests no longer tentative after spec edit. PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682679} -- wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821 wpt-pr: 18185
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682679}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
… spec edit., a=testonly Automatic update from web-platform-tests Overflow tests no longer tentative after spec edit. PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Rune Lillesveen <futharkchromium.org> Cr-Commit-Position: refs/heads/master{#682679} -- wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821 wpt-pr: 18185 UltraBlame original commit: 55d847ea213319d1269eb64f46b24341d7a507e7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
… spec edit., a=testonly Automatic update from web-platform-tests Overflow tests no longer tentative after spec edit. PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Rune Lillesveen <futharkchromium.org> Cr-Commit-Position: refs/heads/master{#682679} -- wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821 wpt-pr: 18185 UltraBlame original commit: 55d847ea213319d1269eb64f46b24341d7a507e7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
… spec edit., a=testonly Automatic update from web-platform-tests Overflow tests no longer tentative after spec edit. PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org> Commit-Queue: Rune Lillesveen <futharkchromium.org> Cr-Commit-Position: refs/heads/master{#682679} -- wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821 wpt-pr: 18185 UltraBlame original commit: 55d847ea213319d1269eb64f46b24341d7a507e7
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
… spec edit., a=testonly Automatic update from web-platform-tests Overflow tests no longer tentative after spec edit. PR landed: w3c/csswg-drafts#4148 Bug: 987207 Change-Id: Ia762000f5c18b7273f84859be1de683fe6aaef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727030 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682679} -- wpt-commits: 69152741bde0991a88c05a8fb98437bc44c90821 wpt-pr: 18185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution: #3779 (comment)