Skip to content

Conversation

@frivoal
Copy link
Collaborator

@frivoal frivoal commented Aug 17, 2019

Fixes #4154

@frivoal frivoal added the selectors-4 Current Work label Aug 17, 2019
@frivoal frivoal requested review from fantasai and r12a August 17, 2019 09:12
@frivoal frivoal self-assigned this Aug 17, 2019
frivoal added a commit to frivoal/csswg-drafts that referenced this pull request Aug 17, 2019
This matches the proposed behavior for selectors 4
(see w3c#4212)
@frivoal frivoal force-pushed the lang-canonicalization branch from 391ead4 to 3cff5d8 Compare August 28, 2019 18:16
Base automatically changed from master to main February 2, 2021 19:45
Copy link
Contributor

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good improvement to the Working Draft, so I'd be ok seeing it optimistically merged.
Are there any tests that exercise this more detailed treatment so we can check existing implementation :lang support to see how well it is already supported (or needs bug fixing)? Also to evaluate any potential webcompat challenges?

@svgeesus
Copy link
Contributor

svgeesus commented Mar 6, 2024

@tantek thanks for the review!

@frivoal This PR from 2019 has of course accumulated merge conflicts in the interim. Could you rebase or otherwise handle these, so it can be merged?

@svgeesus
Copy link
Contributor

svgeesus commented Mar 6, 2024

Closing and re-opening, purely to kick the bot into action. Do not be alarmed.

@svgeesus svgeesus closed this Mar 6, 2024
@svgeesus svgeesus reopened this Mar 6, 2024
@svgeesus svgeesus merged commit f2506ef into w3c:main Mar 6, 2024
@svgeesus
Copy link
Contributor

svgeesus commented Mar 6, 2024

Actually that was a very easy line-rewrapping conflict, so merging.

@frivoal
Copy link
Collaborator Author

frivoal commented Mar 8, 2024

Happy that the two of you liked the PR, but shouldn't we get a WG resolution first?

cc: @astearns @atanassov

@astearns
Copy link
Member

astearns commented Mar 8, 2024

It looks like the corresponding issue stalled with a promise of “further guidance” from the internationalization folks. Perhaps you could mention this issue and the PR on the joint call on the 19th, and then we could either re-open the issue with a call for an async resolution, or re-open the issue with further discussion?

@svgeesus
Copy link
Contributor

svgeesus commented Mar 8, 2024

My apologies, I thought this had a resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

selectors-4 Current Work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider Canonicalization of language tags in :lang() selector maching

4 participants