Skip to content

Defined @namespace using CSS syntax (fixes #649) #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

SebastianZ
Copy link
Contributor

[css-namespaces-3] This replaces the CSS 2.1 syntax used to define the @namespace rule by the newer CSS Syntax 3 rules used in other specs.

@SebastianZ
Copy link
Contributor Author

As I immediately got an error after creating the PR due to not having my GitHub account connected with my W3C account, I've done so now.

@svgeesus svgeesus requested a review from fantasai April 7, 2020 15:22
@svgeesus
Copy link
Contributor

svgeesus commented Apr 7, 2020

@fantasai do you think we should merge this? It is certainly better to use the more modern syntax. Namespaces 3 is a Rec so that would also mean issuing an erratum (which I can help with, if needed). Or indeed we could go through the steps to republish as an updated Recommendation.

I feel this is an editorial change and has no effect on actual implementations.

(I will deal with the IPR bot false positive, if we merge)

@tabatkins
Copy link
Member

I think we should do it; the current definition isn't well-founded since CSS isn't defined over that grammar definition any longer.

@SebastianZ
Copy link
Contributor Author

Sounds like this change could just be merged, but please let me know if I still have to change something.

Sebastian

@fantasai
Copy link
Collaborator

fantasai commented Jul 9, 2020

@svgeesus Given css-syntax-3 is a CR now, and it's effectively editorial, yeah, I think it's fine to merge. I'd want @tabatkins to review the changes though, since I'm not quite as familiar with the new syntax definition requirements. :)

Also, hopefully Process 2020 goes through and we should be able to publish an editorial update to the REC without too much hassle. ^_^

@frivoal frivoal added the css-namespaces-3 Current Work label Jul 14, 2020
@tabatkins
Copy link
Member

r+

@tabatkins tabatkins merged commit 8301df7 into w3c:master Jul 17, 2020
@SebastianZ
Copy link
Contributor Author

Thank you for merging this change, @tabatkins!

Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-namespaces-3 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants