[css-text-3] Hang trailing collapsible other space separators instead of removing them #4290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
379c3ed to
9fa8d0a
Compare
… of removing them Close w3c#4180
9fa8d0a to
6ed3eb9
Compare
fantasai
approved these changes
Sep 10, 2019
kojiishi
reviewed
Sep 10, 2019
Contributor
kojiishi
left a comment
There was a problem hiding this comment.
Thank you for making a PR, it makes easy to review.
| and/or [=other space separators=], | ||
| at the end of a line: | ||
| <ul> | ||
| <li>If 'white-space' is set to ''white-space/normal'', ''white-space/nowrap'', or ''white-space/pre-line'', |
Contributor
There was a problem hiding this comment.
I think the condition is 1) when trailing collapsible spaces are removed, or 2) when trailing collapsible spaces hang. I understand we need some more discussion when to hang for pre-wrap but is this intention agreeable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4180