Skip to content

[css-nav-1] Fix the unreachability for a focusable element inside the search origin #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

jihyerish
Copy link
Contributor

Consider the focusable element which fully overlaps with another focusable element.

Detailed changes are as below:

  1. Add another condition to the definition of 'inside area'

    • To consider the focusable element which fully overlaps with search origin as a candidate for enabling the focus to move there.
  2. Make the difference the way to select 'insider' depending on whether the search origin is a spatial navigation container or not

    • If the search origin is a container, consider the partially visible focusables as the insider.
    • Else (if the search origin is the general element), consider only the fully overlapped focusables as the insider.
      • NOTE: The partially overlapped focusable isn't included in the set of insider.
  3. Modify the way to select candidates among visible focusable elements

    • To measure the distance from the elements which is outside to the search origin.

Close #3386

… search origin

Consider the focusable element which fully overlaps with another focusable element.

Detailed changes are as below:

1. Add another condition to the definition of 'inside area'
  * To consider the focusable element which fully overlaps with search origin as a candidate for enabling the focus to move there.

2. Make the difference the way to select 'insider' depending on wheather the search origin is a spatial navigation container or not
  * If the search origin is container, consider the partially visible focusables as the insider.
  * Else (if the search origin is the general element), consider only the fully overlapped focusables as the insider.
     * NOTE: The partially overlapped focusable isn't included in the set of insider.

3. Modify the way to select candidates among visible focusable elements
  * To measure the distance from the elements which is outside to the search origin.

Close w3c#3386
@jihyerish jihyerish merged commit b528ec2 into w3c:master Sep 25, 2019
@jihyerish jihyerish deleted the revise-select-candidate branch September 25, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-nav-1] Revise selecting best candidate policy
1 participant