-
Notifications
You must be signed in to change notification settings - Fork 716
[css-mediaqueries] Add 'prefers-reduced-data' (addresses #2370) #4575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Content pulled from discussion within #2370
Thanks @huijing, this looks good. One suggestion: could you add a note saying that User Agents may consider setting this based on the same user or system preference as they use to set the Save-Data HTTP request header? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!! :)
non-owner LGTM other than a couple of nits
mediaqueries-5/Overview.bs
Outdated
@media (prefers-reduced-data: reduce) { | ||
/* Save-Data: On */ | ||
.image { | ||
background-image: url("images/heavy.jpg"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "light" and "heavy" switched places :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries :)
mediaqueries-5/Overview.bs
Outdated
or a setting controlled by the User Agent. | ||
|
||
Note: User Agents may consider setting this based on the same user | ||
or system preference as they use to set the Save-Data HTTP request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can point to https://wicg.github.io/savedata/ as a reference link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added link.
Merged! thanks @huijing |
Yay!! 🎉 |
Super excited about this! 😁 |
omg, this is the highlight of my day :) |
Content pulled from discussion within #2370