Skip to content

[cssom] Include custom properties in getComputedStyle(). #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

emilio
Copy link
Collaborator

@emilio emilio commented Apr 13, 2020

Closes #1316. #4947 for the ordering issue.

@emilio
Copy link
Collaborator Author

emilio commented Apr 13, 2020

(Not sure about my english there, is whose correct?)

@tabatkins
Copy link
Member

Yeah, "whose" is correct there, it's okay to lightly anthropomorphize.

@emilio emilio merged commit 44e1510 into master Apr 13, 2020
@emilio emilio deleted the computed-custom-props branch April 13, 2020 19:22
@emilio
Copy link
Collaborator Author

emilio commented Apr 13, 2020

Thanks Tab :)

emilio added a commit to web-platform-tests/wpt that referenced this pull request Apr 13, 2020
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Apr 16, 2020
… in getComputedStyle()., a=testonly

Automatic update from web-platform-tests
[cssom] Add a test for custom properties in getComputedStyle().

Adds a test for w3c/csswg-drafts#1316 /
w3c/csswg-drafts#4948.

--

wpt-commits: 083e3a0abb69de55c66800776b1c1010b1b4ceb5
wpt-pr: 22904
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 16, 2020
… in getComputedStyle()., a=testonly

Automatic update from web-platform-tests
[cssom] Add a test for custom properties in getComputedStyle().

Adds a test for w3c/csswg-drafts#1316 /
w3c/csswg-drafts#4948.

--

wpt-commits: 083e3a0abb69de55c66800776b1c1010b1b4ceb5
wpt-pr: 22904
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Apr 20, 2020
… in getComputedStyle()., a=testonly

Automatic update from web-platform-tests
[cssom] Add a test for custom properties in getComputedStyle().

Adds a test for w3c/csswg-drafts#1316 /
w3c/csswg-drafts#4948.

--

wpt-commits: 083e3a0abb69de55c66800776b1c1010b1b4ceb5
wpt-pr: 22904

UltraBlame original commit: 62f65b3c9d666a78da5d64d4f75bec31101359e7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Apr 20, 2020
… in getComputedStyle()., a=testonly

Automatic update from web-platform-tests
[cssom] Add a test for custom properties in getComputedStyle().

Adds a test for w3c/csswg-drafts#1316 /
w3c/csswg-drafts#4948.

--

wpt-commits: 083e3a0abb69de55c66800776b1c1010b1b4ceb5
wpt-pr: 22904

UltraBlame original commit: 62f65b3c9d666a78da5d64d4f75bec31101359e7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Apr 20, 2020
… in getComputedStyle()., a=testonly

Automatic update from web-platform-tests
[cssom] Add a test for custom properties in getComputedStyle().

Adds a test for w3c/csswg-drafts#1316 /
w3c/csswg-drafts#4948.

--

wpt-commits: 083e3a0abb69de55c66800776b1c1010b1b4ceb5
wpt-pr: 22904

UltraBlame original commit: 62f65b3c9d666a78da5d64d4f75bec31101359e7
@syncbot syncbot restored the computed-custom-props branch July 1, 2020 16:44
@plinss plinss deleted the computed-custom-props branch July 13, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cssom] should custom properties be exposed on computed style declarations?
2 participants