-
Notifications
You must be signed in to change notification settings - Fork 756
[cssom-1] Improve accuracy of <color> serialization #4967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
svgeesus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS WG decided at the A Coruna meeting to move the color serialization from CSS OM to Color 4.
Also, while implementations were historically limited to 8 bits (and thus, integers in the range 0 to 255) this is being changed, to allow higher precision while keeping the historical 0 to 255 range; thus, these would no longer be integers.
These values come from the fact that many graphics engines store the color channels internally as a single byte, which can hold integers between 0 and 255. Implementations should honor the precision of the channel as authored or calculated wherever possible. If this is not possible, the channel should be rounded to the closest value at the highest precision used, rounding up if two values are equally close.
https://drafts.csswg.org/css-color-4/#rgb-functions
Thanks. I’ve updated the patch accordingly. |
|
I think we should merge this change, but the IPR bot is angry :( |
emilio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyhow looks good.
|
The IPR bot report takes me to https://www.w3.org/2004/01/pp-impl/32061/join, which explains there's a form I should fill out, but all links point to the same document (which doesn't contain any forms as far as I can tell). 🤔 Is there a way for me to waive my IPR on this silly one-word patch? I am a W3C invited expert and work for a W3C member organization. |
|
Marked as non substantive for IPR from ash-nazg. |
That is the "join the CSS WG" form, which is filled out by the AC Rep not the participant. I suspect your W3C account and your GitHub account are not linked, so the bot does not know who you are. |
Either the word "integer" was missing from most of these steps, or it was accidentally added in one step.
This patch assumes the former.