Skip to content

Conversation

@mathiasbynens
Copy link
Contributor

@mathiasbynens mathiasbynens commented Apr 17, 2020

Either the word "integer" was missing from most of these steps, or it was accidentally added in one step. This patch assumes the former.

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS WG decided at the A Coruna meeting to move the color serialization from CSS OM to Color 4.

Also, while implementations were historically limited to 8 bits (and thus, integers in the range 0 to 255) this is being changed, to allow higher precision while keeping the historical 0 to 255 range; thus, these would no longer be integers.

These values come from the fact that many graphics engines store the color channels internally as a single byte, which can hold integers between 0 and 255. Implementations should honor the precision of the channel as authored or calculated wherever possible. If this is not possible, the channel should be rounded to the closest value at the highest precision used, rounding up if two values are equally close.
https://drafts.csswg.org/css-color-4/#rgb-functions

@mathiasbynens
Copy link
Contributor Author

Also, while implementations were historically limited to 8 bits (and thus, integers in the range 0 to 255) this is being changed, to allow higher precision while keeping the historical 0 to 255 range; thus, these would no longer be integers.

Thanks. I’ve updated the patch accordingly.

@frivoal frivoal added the cssom-1 Current Work label Jul 14, 2020
@emilio
Copy link
Collaborator

emilio commented Sep 3, 2020

I think we should merge this change, but the IPR bot is angry :(

Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyhow looks good.

@mathiasbynens
Copy link
Contributor Author

The IPR bot report takes me to https://www.w3.org/2004/01/pp-impl/32061/join, which explains there's a form I should fill out, but all links point to the same document (which doesn't contain any forms as far as I can tell). 🤔 Is there a way for me to waive my IPR on this silly one-word patch? I am a W3C invited expert and work for a W3C member organization.

@mathiasbynens
Copy link
Contributor Author

Marked as non substantive for IPR from ash-nazg.

@emilio emilio merged commit b590c9d into w3c:master Sep 3, 2020
@svgeesus
Copy link
Contributor

svgeesus commented Sep 4, 2020

The IPR bot report takes me to https://www.w3.org/2004/01/pp-impl/32061/join, which explains there's a form I should fill out,

That is the "join the CSS WG" form, which is filled out by the AC Rep not the participant.

I suspect your W3C account and your GitHub account are not linked, so the bot does not know who you are.

@mathiasbynens mathiasbynens deleted the patch-2 branch October 19, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cssom-1 Current Work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants