Skip to content

[css-scroll-anchoring-1] Add priority candidates for scroll anchor selection #5018 #5050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2020

Conversation

vmpstr
Copy link
Member

@vmpstr vmpstr commented May 7, 2020

The PR adds scroll anchoring priority candidates which would be used before the DOM order children are considered as scroll anchors.

#5018

@vmpstr vmpstr requested a review from emilio May 8, 2020 15:50
@vmpstr vmpstr requested a review from emilio May 8, 2020 19:42
@vmpstr vmpstr requested a review from emilio May 11, 2020 14:24
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, thanks!

@vmpstr
Copy link
Member Author

vmpstr commented May 13, 2020

I removed the insertion caret from the priority lists, since I think having the focused element be prioritized over it largely handles it. In other words, I'm failing to come up with any reasonable example that has an insertion caret but not a focused element.

@tabatkins tabatkins merged commit 396d0cf into w3c:master May 13, 2020
@emilio
Copy link
Collaborator

emilio commented May 14, 2020

Caret browsing in Gecko?

@vmpstr
Copy link
Member Author

vmpstr commented May 14, 2020

It was specified as insertion caret here in the text here: https://drafts.csswg.org/css-ui-3/#propdef-caret-color

I think the Gecko caret browsing is what the non-normative text refers to as a navigation caret. We can definitely add that back in, but perhaps with different wording

@vmpstr vmpstr deleted the anchor-selection-update branch May 14, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants