Skip to content

[css-images-4] Added <element()> to <image> data type #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

SebastianZ
Copy link
Contributor

Closes #5170

@LeaVerou
Copy link
Member

LeaVerou commented Jun 5, 2020

The edit seems fine with me, though not sure about the IPR warning. @svgeesus can I still merge this?

@svgeesus
Copy link
Contributor

svgeesus commented Jun 5, 2020

Hi @SebastianZ could you please link your W3C account to your GitHub account because our IPR bot doesn't know who you are.

@SebastianZ
Copy link
Contributor Author

Ah, I thought connecting my account on that page would be enough and I already did that back in 2019.

GitHub account connected to W3C account

Though I additionally needed to connect the Repository Manager to my GitHub account, which I did now.

Sebastian

@SebastianZ
Copy link
Contributor Author

SebastianZ commented Jun 8, 2020

Hmm, but it still fails. 😞 Any hint what is missing?

Sebastian

@SebastianZ
Copy link
Contributor Author

Could it be that my request to join the CSSWG never got accepted? At least my profile page indicates that saying

Application for Cascading Style Sheets (CSS) Working Group on 2019/11/22
Status for this application new

@LeaVerou
Copy link
Member

LeaVerou commented Jun 9, 2020

I suspect someone needs to revalidate, but the app is failing to load the PR for me after I login. @svgeesus, could you help?

@LeaVerou
Copy link
Member

LeaVerou commented Jun 9, 2020

Oh, I just noticed you have connected your Github account since 2019, so it can't have been that. I don't know what it is then. Again, someone from W3C needs to look into this, so let's wait for @svgeesus

@SebastianZ
Copy link
Contributor Author

After accepting my request to be an invited expert (thank you!) it looks like the Repository Manger doesn't have any issues with the request anymore but the checks still fail.

Is there anything left I have to do in order to make the ipr bot happy?

Sebastian

@frivoal frivoal merged commit 042223a into w3c:master Jul 14, 2020
@SebastianZ
Copy link
Contributor Author

Thank you again, @frivoal!

Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

element() should be part of <image>
4 participants