[scroll-animations-1][web-animations-1] Added phase calculation for ScrollTimeline #4325 #5186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogerchikov
reviewed
Jun 9, 2020
ogerchikov
reviewed
Jun 9, 2020
birtles
requested changes
Jun 12, 2020
birtles
approved these changes
Jun 16, 2020
birtles
reviewed
Jun 16, 2020
added 8 commits
June 18, 2020 10:27
…itions to the animation effect phase calculation to account for timeline phase.
fc5acdd to
24a6f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added section describing how scroll timeline phase is calculated. Inclusive end exception that was removed in a previous PR has been added back in through the phase calculation (an explanatory note for the exception has been included).
I also reformatted the section for calculating current time to match the new phase calculation formatting.