[css-images-3] image-orientation: none applies to non-decorative images too. #5245
#5294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm adding tests in https://phabricator.services.mozilla.com/D82471. |
Collaborator
|
Sorry for taking so long on this; there were a number of adjustments I knew I wanted to make so I procrastinated a lot on the review. But thanks for making sure the spec covers a wide range of the implications of the WG resolution! Pushed some edits to the spec, which are better for having your PR to work from. :) I think we still have a bit of adjustment to do to clearly describe e.g. the SVG cases, so I'm going to leave this PR open until we're 100% sure we covered everything you have here. |
fantasai
added a commit
that referenced
this pull request
Nov 12, 2020
Collaborator
|
OK. I think I've got everything covered now @heycam. Feel free to review and complain if not. :) In the meantime, I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5245.